Re: SPDY support

2012-03-25 Thread Costin Manolache
On Sun, Mar 25, 2012 at 5:58 PM, Bill Barker wrote: > > > "Mark Thomas" wrote in message news:4F6F8735.3090706@apache.**org... > > > On 25/03/2012 17:24, Costin Manolache wrote: > >> For Tomcat7 I'm proposing to only add hooks: 'beforeHandshake' callback in >>> Handler, and an optional NpnHandler

Re: SPDY support

2012-03-25 Thread Bill Barker
"Mark Thomas" wrote in message news:4f6f8735.3090...@apache.org... On 25/03/2012 17:24, Costin Manolache wrote: For Tomcat7 I'm proposing to only add hooks: 'beforeHandshake' callback in Handler, and an optional NpnHandler class plus setters in protocol. There is no Java7 or spdy dependency

Re: SPDY support

2012-03-25 Thread Mark Thomas
On 25/03/2012 17:24, Costin Manolache wrote: > For Tomcat7 I'm proposing to only add hooks: 'beforeHandshake' callback in > Handler, and an optional NpnHandler class plus setters in protocol. > There is no Java7 or spdy dependency at all. Sounds good to me. > The main question is if it's ok to ad

Re: SPDY support

2012-03-25 Thread Costin Manolache
7;m proposing for tomcat7. Costin > Filip > > - Original Message - > > From: "Costin Manolache" > > To: "Tomcat Developers List" > > Sent: Saturday, March 24, 2012 10:44:19 PM > > Subject: Re: SPDY support > > > > Hi, > &

Re: SPDY support

2012-03-25 Thread Filip Hanik Mailing Lists
itory? Filip - Original Message - > From: "Costin Manolache" > To: "Tomcat Developers List" > Sent: Saturday, March 24, 2012 10:44:19 PM > Subject: Re: SPDY support > > Hi, > > I did a first round of backporting to tomcat7 - only the hooks. &g

Re: SPDY support

2012-03-24 Thread Costin Manolache
Hi, I did a first round of backporting to tomcat7 - only the hooks. Please take a look and let me know: https://github.com/costinm/tomcat/blob/trunk/tomcat7.diff I've also submitted to git the changes to support SPDY/NPN for NIO and JIO connectors - almost same diff, but the important change is

Re: SPDY support

2012-03-19 Thread Costin Manolache
On Mon, Mar 19, 2012 at 10:43 AM, Gus Heck wrote: > I just bumped into the whole concept of SPDY this morning, and it sounds > fabulous, and I'm quite happy to see that it's already underway in trunk. > I'm quite likely to be using a lot of development using Vaadin framework in > the near future,

Re: SPDY support

2012-03-14 Thread Costin Manolache
Yes. Chrome is enabled by default and used for all connections to google, and it has a nice debug interface (chrome://net-internals/#sockets ). You can select 'capture -> include bytes', than in events you can see all frames, and in 'spdy' you see the live connections. Also can start it with "--us

Re: SPDY support

2012-03-14 Thread Konstantin Kolinko
2012/2/2 Costin Manolache : > > Some initial patch for SPDY - using the NPN SSL extension, as required by > chrome/firefox. > Firefox 11.0 that just has been released as stable has support for SPDY. It is disabled by default. According to the docs, "To use it right now you'll need to set network.

Re: SPDY support

2012-03-12 Thread Costin Manolache
Submitted the second part - please let me know if there are concerns with the layout/etc. Note that Jetty announced spdy support as well, and they're using a NPN implementation that requires Java7. Their NPN library seems to have ASF licence ( dual eclipse/asf ), I'll try to get it working with th

Re: SPDY support

2012-02-22 Thread Costin Manolache
On Wed, Feb 22, 2012 at 10:47 AM, Mark Thomas wrote: > On 22/02/2012 18:41, Costin Manolache wrote: > > On Wed, Feb 22, 2012 at 10:27 AM, Konstantin Kolinko < > knst.koli...@gmail.com > >> wrote: > > > >> 2012/2/22 Costin Manolache : > >>> On Wed, Feb 22, 2012 at 8:57 AM, Mark Thomas wrote: > >>

Re: SPDY support

2012-02-22 Thread Mark Thomas
On 22/02/2012 18:41, Costin Manolache wrote: > On Wed, Feb 22, 2012 at 10:27 AM, Konstantin Kolinko > wrote: > >> 2012/2/22 Costin Manolache : >>> On Wed, Feb 22, 2012 at 8:57 AM, Mark Thomas wrote: >>> On 22/02/2012 16:51, Costin Manolache wrote: > First part submitted. For the second:

Re: SPDY support

2012-02-22 Thread Costin Manolache
On Wed, Feb 22, 2012 at 10:27 AM, Konstantin Kolinko wrote: > 2012/2/22 Costin Manolache : > > On Wed, Feb 22, 2012 at 8:57 AM, Mark Thomas wrote: > > > >> On 22/02/2012 16:51, Costin Manolache wrote: > >> > First part submitted. For the second: what is the process for adding a > >> > dependency

Re: SPDY support

2012-02-22 Thread Konstantin Kolinko
2012/2/22 Costin Manolache : > On Wed, Feb 22, 2012 at 8:57 AM, Mark Thomas wrote: > >> On 22/02/2012 16:51, Costin Manolache wrote: >> > First part submitted. For the second: what is the process for adding a >> > dependency ? >> >> Why do you need the dependency? >> > > Spdy requires header compr

Re: SPDY support

2012-02-22 Thread Costin Manolache
On Wed, Feb 22, 2012 at 8:57 AM, Mark Thomas wrote: > On 22/02/2012 16:51, Costin Manolache wrote: > > First part submitted. For the second: what is the process for adding a > > dependency ? > > Why do you need the dependency? > Spdy requires header compression - with a pre-defined dictionary (

Re: SPDY support

2012-02-22 Thread Mark Thomas
On 22/02/2012 16:51, Costin Manolache wrote: > First part submitted. For the second: what is the process for adding a > dependency ? Why do you need the dependency? > jzlib is BSD - I added it to 'download' and build.properties. LICENSE and NOTICE need updating as well (multiple locations). So w

Re: SPDY support

2012-02-22 Thread Costin Manolache
First part submitted. For the second: what is the process for adding a dependency ? jzlib is BSD - I added it to 'download' and build.properties. I can make it optional (i.e. skip building the code that depend on it if jzlib is missing ), but it doesn't seem to be worth it. Do automatic builders r

Re: SPDY support

2012-02-16 Thread Mark Thomas
On 16/02/2012 01:44, Costin Manolache wrote: > That doesn't mean the application must receive the entire message as one > byte[] > or as a Stream. > You can have a very large fragment but still read it in smaller buffers and > notify > the user of message start and for each fragment ( I guess like

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 12:10 PM, Mark Thomas wrote: > On 15/02/2012 19:58, Costin Manolache wrote: > > In spdy I'm using a SpdyFrame class ( spdy allow data frames to be > > fragmented any > > way you want by intermediary - so even if I receive a huge frame, I can > > split it > > in buffer-size

Re: SPDY support

2012-02-15 Thread Mark Thomas
On 15/02/2012 19:58, Costin Manolache wrote: > In spdy I'm using a SpdyFrame class ( spdy allow data frames to be > fragmented any > way you want by intermediary - so even if I receive a huge frame, I can > split it > in buffer-sized frames - I believe you can do the same for websocket, as > long

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 10:31 AM, Mark Thomas wrote: > On 15/02/2012 16:11, Costin Manolache wrote: > > After I submit, I'll give a try to changing SocketWrapper (non-generic, > > add read/write), in the git. If you don't like it - easy to drop the > branch, > > but I think it'll simplify the old

Re: SPDY support

2012-02-15 Thread Mark Thomas
On 15/02/2012 16:11, Costin Manolache wrote: > After I submit, I'll give a try to changing SocketWrapper (non-generic, > add read/write), in the git. If you don't like it - easy to drop the branch, > but I think it'll simplify the old connectors enough to compensate for the > extra complexity I'm a

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 12:34 AM, Mark Thomas wrote: > > > Processor is tied to one request/response - Spdy protocol is a > multiplexing > > protocol, so one spdy connection will have 100s of Requests. > > I am using Processor interface for each muxed spdy stream. > > Hmm. I wonder if we need a d

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 12:56 AM, Mladen Turk wrote: > On 02/15/2012 04:53 AM, Costin Manolache wrote: > >> Uploaded another take. >> >> >> For non-SSL ( JIO, and apr without ssl ) -> SPDY just kicks in on all >> connections, >> this is just a short-cut for testing. I could also define a SpdyPro

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 6:33 AM, Mark Thomas wrote: > On 15/02/2012 03:53, Costin Manolache wrote: > > Uploaded another take. > > > > This time I'm just adding > > > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/LightHandler.java > > > > which is just a Handler - li

Re: SPDY support

2012-02-15 Thread Mark Thomas
On 15/02/2012 03:53, Costin Manolache wrote: > Uploaded another take. > > This time I'm just adding > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/LightHandler.java > > which is just a Handler - like AjpConnectionHandler, > Http11ConnectionHandler. > > I believe t

Re: SPDY support

2012-02-15 Thread Mladen Turk
On 02/15/2012 04:53 AM, Costin Manolache wrote: Uploaded another take. For non-SSL ( JIO, and apr without ssl ) -> SPDY just kicks in on all connections, this is just a short-cut for testing. I could also define a SpdyProtocol and set it directly on the connector - but seems too much overhead

Re: SPDY support

2012-02-15 Thread Mark Thomas
On 15/02/2012 03:53, Costin Manolache wrote: > Uploaded another take. > > This time I'm just adding > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/LightHandler.java > > which is just a Handler - like AjpConnectionHandler, > Http11ConnectionHandler. > > I believe t

Re: SPDY support

2012-02-14 Thread Costin Manolache
Uploaded another take. This time I'm just adding https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/LightHandler.java which is just a Handler - like AjpConnectionHandler, Http11ConnectionHandler. I believe this is as close to Endpoint intent as it can be - given this is

Re: SPDY support

2012-02-14 Thread Mark Thomas
On 14/02/2012 21:03, Costin Manolache wrote: > BTW - one thing that may simplify the existing code is replacing > SocketWrapper with a simple SocketWrapper, and having JIO and APR > define their own SocketWrapper - like NIO does. Worth adding to the 8.0.x TODO list. > It would also save a lot of

Re: SPDY support

2012-02-14 Thread Mark Thomas
On 14/02/2012 20:47, Costin Manolache wrote: > On Tue, Feb 14, 2012 at 9:36 AM, Mark Thomas wrote: > >> On 14/02/2012 08:29, Costin Manolache wrote: >>> Ok, took a bit to get the Apr polling to work and add some minimal tests. >>> >>> Please take another look - in particular to >>> >> https://git

Re: SPDY support

2012-02-14 Thread Costin Manolache
BTW - one thing that may simplify the existing code is replacing SocketWrapper with a simple SocketWrapper, and having JIO and APR define their own SocketWrapper - like NIO does. It would also save a lot of Long->long->Long boxing. I'll try replacing Protocol/Processor with Handler, see how it lo

Re: SPDY support

2012-02-14 Thread Costin Manolache
On Tue, Feb 14, 2012 at 9:36 AM, Mark Thomas wrote: > On 14/02/2012 08:29, Costin Manolache wrote: > > Ok, took a bit to get the Apr polling to work and add some minimal tests. > > > > Please take another look - in particular to > > > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/t

Re: SPDY support

2012-02-14 Thread Mark Thomas
On 14/02/2012 08:29, Costin Manolache wrote: > Ok, took a bit to get the Apr polling to work and add some minimal tests. > > Please take another look - in particular to > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java > > The spdy implementation seem

Re: SPDY support

2012-02-14 Thread Yoav Shapira
On Tue, Feb 14, 2012 at 3:29 AM, Costin Manolache wrote: > Ok, took a bit to get the Apr polling to work and add some minimal tests. > > Please take another look - in particular to > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java > > The spdy implemen

Re: SPDY support

2012-02-14 Thread Costin Manolache
Ok, took a bit to get the Apr polling to work and add some minimal tests. Please take another look - in particular to https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java The spdy implementation seems to work with chrome, and the client seems to work with

Re: SPDY support

2012-02-03 Thread Pid
On 02/02/2012 13:30, Remy Maucherat wrote: > On Thu, 2012-02-02 at 12:28 +, Pid wrote: >>> Of course, I'm even less sure about websockets since it's kind of a mess. >> >> I'd say it was the other way round. WebSockets finalised before Xmas, >> and there's lots of interest from various communit

Re: SPDY support

2012-02-02 Thread Mark Thomas
On 02/02/2012 14:14, Costin Manolache wrote: > On Thu, Feb 2, 2012 at 3:33 AM, Mark Thomas wrote: > >> On 02/02/2012 10:05, Remy Maucherat wrote: >>> Ok, I think your "light protocol" concept to group any "upgraded" >>> connections is appropriate. >> >> Agreed. I'll see if I can wrap this into t

Re: SPDY support

2012-02-02 Thread Costin Manolache
On Thu, Feb 2, 2012 at 3:33 AM, Mark Thomas wrote: > On 02/02/2012 10:05, Remy Maucherat wrote: > > On Wed, 2012-02-01 at 13:54 -0800, Costin Manolache wrote: > >> Hi, > >> > >> Some initial patch for SPDY - using the NPN SSL extension, as required > by > >> chrome/firefox. > >> > >> I used githu

Re: SPDY support

2012-02-02 Thread Remy Maucherat
On Thu, 2012-02-02 at 12:28 +, Pid wrote: > > Of course, I'm even less sure about websockets since it's kind of a mess. > > I'd say it was the other way round. WebSockets finalised before Xmas, > and there's lots of interest from various communities to judge from the BZ. Websocrap is a bad t

Re: SPDY support

2012-02-02 Thread Pid
On 02/02/2012 10:05, Remy Maucherat wrote: > On Wed, 2012-02-01 at 13:54 -0800, Costin Manolache wrote: >> Hi, >> >> Some initial patch for SPDY - using the NPN SSL extension, as required by >> chrome/firefox. >> >> I used github so it's easy to add comments or test: >> >> https://github.com/costin

Re: SPDY support

2012-02-02 Thread Mark Thomas
On 02/02/2012 10:05, Remy Maucherat wrote: > On Wed, 2012-02-01 at 13:54 -0800, Costin Manolache wrote: >> Hi, >> >> Some initial patch for SPDY - using the NPN SSL extension, as required by >> chrome/firefox. >> >> I used github so it's easy to add comments or test: >> >> https://github.com/costin

Re: SPDY support

2012-02-02 Thread Remy Maucherat
On Wed, 2012-02-01 at 13:54 -0800, Costin Manolache wrote: > Hi, > > Some initial patch for SPDY - using the NPN SSL extension, as required by > chrome/firefox. > > I used github so it's easy to add comments or test: > > https://github.com/costinm/tomcat/commit/e97def3314216c083cc4b68ad9731e5a94

Re: SPDY support

2012-02-01 Thread Henri Gomez
Github :-) Le 1 févr. 2012 à 22:54, Costin Manolache a écrit : > Hi, > > Some initial patch for SPDY - using the NPN SSL extension, as required by > chrome/firefox. > > I used github so it's easy to add comments or test: > > https://github.com/costinm/tomcat/commit/e97def3314216c083cc4b68ad97