Re: Rewrite features

2005-11-04 Thread Remy Maucherat
Bill Barker wrote: The TomcatResolver instance is holding a reference to the Request instance, and is in a TL. As a result (because of the way the ThreadPool works) it will live very much longer than just during the processing of a given Request. This is all fine for all of the current Connecto

RE: Rewrite features

2005-11-04 Thread Allistair Crossley
Tomcat Developers List > Subject: Re: Rewrite features > > > Hi, > Cool, I like it. Two questions: > > - Why the RewriteMap interface? It does seem to add much > over a normal Map, > and I doubt you're targeting JDK 1.1 compatibility ;) > > - Seems like thi

Re: Rewrite features

2005-11-03 Thread Bill Barker
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Thursday, November 03, 2005 12:18 PM Subject: Re: Rewrite features >Bill Barker wrote: >> We don't unbind the service() from the Thread. However,

Re: Rewrite features

2005-11-03 Thread Bill Barker
- Original Message - From: "Remy Maucherat" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Thursday, November 03, 2005 12:11 PM Subject: Re: Rewrite features >Costin Manolache wrote: >> On 11/3/05, Bill Barker <[EMAIL PROTECTED]> wrote

Re: Rewrite features

2005-11-03 Thread Costin Manolache
On 11/3/05, Bill Barker <[EMAIL PROTECTED]> wrote: > > - Original Message - > From: "Costin Manolache" <[EMAIL PROTECTED]> > To: "Tomcat Developers List" > Sent: Thursday, November 03, 2005 11:30 AM > Subject: Re: Rewrite features >

Re: Rewrite features

2005-11-03 Thread Remy Maucherat
Bill Barker wrote: We don't unbind the service() from the Thread. However, in Coyote Request instances are very long lived objects that (at least for HTTP/1.1) persist over many connections. The APR Connector uses a ThreadLocal to bind the Request instance to a single Thread instance. The next

Re: Rewrite features

2005-11-03 Thread Remy Maucherat
Costin Manolache wrote: On 11/3/05, Bill Barker <[EMAIL PROTECTED]> wrote: It probably doesn't matter (since nobody uses it :), but using ThreadLocal won't work with the Nio/AJP Connector. That one doesn't bind a Request instance to a Thread instance, so a particular Request instance will proc

Re: Rewrite features

2005-11-03 Thread Bill Barker
- Original Message - From: "Costin Manolache" <[EMAIL PROTECTED]> To: "Tomcat Developers List" Sent: Thursday, November 03, 2005 11:30 AM Subject: Re: Rewrite features On 11/3/05, Bill Barker <[EMAIL PROTECTED]> wrote: >> It probably doesn't

Re: Rewrite features

2005-11-03 Thread Costin Manolache
On 11/3/05, Bill Barker <[EMAIL PROTECTED]> wrote: > It probably doesn't matter (since nobody uses it :), but using ThreadLocal > won't work with the Nio/AJP Connector. That one doesn't bind a Request > instance to a Thread instance, so a particular Request instance will process > on many differen

Re: Rewrite features

2005-11-03 Thread Yoav Shapira
Hi, > The reason I ask - I'm playing with coyote standalone, I have a > trivial mapper, file server, hello world adapter - for simple http > serving. I would love, love, love to see this. What's the download footprint size? Thanks, Yoav Yoav Shapira System Design and Management Fellow MIT Sl

Re: Rewrite features

2005-11-03 Thread Bill Barker
It probably doesn't matter (since nobody uses it :), but using ThreadLocal won't work with the Nio/AJP Connector. That one doesn't bind a Request instance to a Thread instance, so a particular Request instance will process on many different Threads during its lifecycle. The alternative (which, IM

Re: Rewrite features

2005-11-03 Thread Costin Manolache
Have you considered placing it at a lower level, as a coyote adapter ? The reason I ask - I'm playing with coyote standalone, I have a trivial mapper, file server, hello world adapter - for simple http serving. This would fit well before entering the servlet engine. Costin On 11/3/05, Remy Mauche

Re: Rewrite features

2005-11-03 Thread Remy Maucherat
Yoav Shapira wrote: Hi, Cool, I like it. Two questions: - Why the RewriteMap interface? It does seem to add much over a normal Map, and I doubt you're targeting JDK 1.1 compatibility ;) It's not a map (at least not a Java map). mod_rewrite calls the directive RewriteMap. - Seems like thi

Re: Rewrite features

2005-11-03 Thread Yoav Shapira
Hi, Cool, I like it. Two questions: - Why the RewriteMap interface? It does seem to add much over a normal Map, and I doubt you're targeting JDK 1.1 compatibility ;) - Seems like this could be easily done as a Filter instead of Valve. The lifecycle support would be a bit different, start -> in