Re: PreDestroy annotation handling

2013-01-05 Thread Christopher Schultz
Konstantin, On 1/5/13 6:31 PM, Konstantin Kolinko wrote: > 2013/1/6 Christopher Schultz : >> >> On 1/5/13 12:52 PM, Konstantin Kolinko wrote: >>> 2) Calling PreDestroy methods if init() method fails. >>> >>> The specs say that >>> - if @PostConstruct methods fail then nothing is called afterwards,

Re: PreDestroy annotation handling

2013-01-05 Thread Konstantin Kolinko
2013/1/6 Christopher Schultz : > > On 1/5/13 12:52 PM, Konstantin Kolinko wrote: >> 2) Calling PreDestroy methods if init() method fails. >> >> The specs say that >> - if @PostConstruct methods fail then nothing is called afterwards, and >> - if init() fails then destroy() is not called. >> >> I wo

Re: PreDestroy annotation handling

2013-01-05 Thread Mark Thomas
Konstantin Kolinko wrote: >1) Calling PreDestroy methods if destroy() method fails. > >I think that PreDestroy methods should be called even if destroy() >fails. >For Filters it was fixed by r1428645 . For Servlets this is yet to be >fixed. > >I think this has to be fixed, similar to r1428645.

Re: PreDestroy annotation handling

2013-01-05 Thread Christopher Schultz
Konstantin, On 1/5/13 12:52 PM, Konstantin Kolinko wrote: > 2) Calling PreDestroy methods if init() method fails. > > The specs say that > - if @PostConstruct methods fail then nothing is called afterwards, and > - if init() fails then destroy() is not called. > > I wonder whether failure of ini