Re: Offline generation of effective web.xml

2012-12-03 Thread Mark Thomas
On 03/12/2012 14:51, Violeta Georgieva wrote: >> >> From which git repository? I couldn't find that commit ID in the ASF git >> repo for Tomcat trunk nor the GitHub mirror. > > > Ok I understood where the missunderstanding is. > That repo (in my github profile) is my own git-to-svn repo and is no

Re: Offline generation of effective web.xml

2012-12-03 Thread Violeta Georgieva
> > From which git repository? I couldn't find that commit ID in the ASF git > repo for Tomcat trunk nor the GitHub mirror. Ok I understood where the missunderstanding is. That repo (in my github profile) is my own git-to-svn repo and is not a fork from the one available in github. Having my own

Re: Offline generation of effective web.xml

2012-12-03 Thread Mark Thomas
On 03/12/2012 08:51, Violeta Georgieva wrote: > Hi Mark, > >> OK. First question. How did you create your git repo? I am trying to add >> your repo as a remote repo to my own but there are no common ancestors. >> I think I can hack around this but I'd like to understand how it >> happened in the f

Re: Offline generation of effective web.xml

2012-12-03 Thread Violeta Georgieva
Hi Mark, > OK. First question. How did you create your git repo? I am trying to add > your repo as a remote repo to my own but there are no common ancestors. > I think I can hack around this but I'd like to understand how it > happened in the first place. > I'm using "git svn". The last rebase th

Re: Offline generation of effective web.xml

2012-11-30 Thread Mark Thomas
On 30/11/2012 11:41, Mark Thomas wrote: > I'm starting to look at this now. The general description above looks to > be heading in the right direction. They'll probably be some tweaks at > the detail level. > > This is my first time trying to pull in changes from someone's branch at > github so I'

Re: Offline generation of effective web.xml

2012-11-30 Thread Mark Thomas
On 22/11/2012 19:46, Violeta Georgieva wrote: > Hi, > > I've prepared the initial change for offline generation of effective > web.xml. > The change is in github: > https://github.com/violetagg/apache-tomcat-8.0/commits/master. > I have a few minor changes that I plan to do but before then I prefe

Re: Offline generation of effective web.xml

2012-11-22 Thread Violeta Georgieva
Hi, I've prepared the initial change for offline generation of effective web.xml. The change is in github: https://github.com/violetagg/apache-tomcat-8.0/commits/master. I have a few minor changes that I plan to do but before then I prefer to get your opinion about the refactoring that I made and