Re: NIO buffering

2014-04-23 Thread Rémy Maucherat
2014-04-23 18:30 GMT+02:00 Mark Thomas : > I'd agree with that assessment. > > I do remember having to be very careful with some of that code to get > things working correctly. If there is a cleaner solution then I'd be all > for it as long as performance is no worse. > > Mark > > [1] http://svn.a

Re: NIO buffering

2014-04-23 Thread Mark Thomas
On 23/04/2014 16:30, Filip Hanik wrote: > Ok, Mark would know the exact details. I'm not sure where you got that idea from, you introduced this code [1]. > It simply looks like a when a buffer > has been flipped already, to simplify adding more bytes, add it to a new > unflipped buffer, rather th

Re: NIO buffering

2014-04-23 Thread Filip Hanik
Ok, Mark would know the exact details. It simply looks like a when a buffer has been flipped already, to simplify adding more bytes, add it to a new unflipped buffer, rather than append to existing one. So I don't think its about reuse, I think it may be to simplify the handling of buffer flipping.

Re: NIO buffering

2014-04-23 Thread Rémy Maucherat
2014-04-23 16:50 GMT+02:00 Filip Hanik : > >I am not convinced by the NIO buffering that is used on output. > > what are you exactly referring to? Maybe I can shed some light on it. > Ok, so more precisely I was talking about the AbstractOutputBuffer.bufferedWrites field. Rémy > > > On Fri, Ap

Re: NIO buffering

2014-04-23 Thread Filip Hanik
>I am not convinced by the NIO buffering that is used on output. what are you exactly referring to? Maybe I can shed some light on it. On Fri, Apr 18, 2014 at 1:30 PM, Rémy Maucherat wrote: > Hi, > > I am not convinced by the NIO buffering that is used on output. Due to > concurrent access iss