Re: Micro-optimizations

2019-05-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Martin, On 5/8/19 13:58, Martin Grigorov wrote: > Hi, > > On Wed, May 8, 2019 at 7:16 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > > All, > > While working on the sort-file-listing enhancement over the > weekend, I looked in

Re: Micro-optimizations

2019-05-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 5/8/19 12:35, Mark Thomas wrote: > On 08/05/2019 17:30, Christopher Schultz wrote: >> >> Back to JspUtil.split. It's private and used exactly one place. >> AND it's only ever called with a single-character String value. >> So actually the

Re: Micro-optimizations

2019-05-08 Thread Martin Grigorov
Hi, On Wed, May 8, 2019 at 7:16 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > While working on the sort-file-listing enhancement over the weekend, I > looked in the Tomcat code to see if we already had a method to sp

Re: Micro-optimizations

2019-05-08 Thread Mark Thomas
On 08/05/2019 17:30, Christopher Schultz wrote: > Mark, > > On 5/8/19 12:20, Mark Thomas wrote: >> On 08/05/2019 17:16, Christopher Schultz wrote: >>> All, >>> >>> While working on the sort-file-listing enhancement over the >>> weekend, I looked in the Tomcat code to see if we already had a >>> me

Re: Micro-optimizations

2019-05-08 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 5/8/19 12:20, Mark Thomas wrote: > On 08/05/2019 17:16, Christopher Schultz wrote: >> All, >> >> While working on the sort-file-listing enhancement over the >> weekend, I looked in the Tomcat code to see if we already had a >> method to sp

Re: Micro-optimizations

2019-05-08 Thread Mark Thomas
On 08/05/2019 17:16, Christopher Schultz wrote: > All, > > While working on the sort-file-listing enhancement over the weekend, I > looked in the Tomcat code to see if we already had a method to split a > string by a single character. The closest method I found was > org.pache.jasper.compiler.JspU