Re: Error handling

2014-06-06 Thread Mark Thomas
On 06/06/2014 18:01, Mark Thomas wrote: > On 06/06/2014 12:29, Konstantin Kolinko wrote: > > > >> Reviewing r1600449 and followups. >> >> // ErrorReportValve.java >> [[[ >> if (response.isCommitted()) { >> if (response.isErrorAfterCommit()) { >> // Flush any d

Re: Error handling

2014-06-06 Thread Mark Thomas
On 06/06/2014 12:29, Konstantin Kolinko wrote: > Reviewing r1600449 and followups. > > // ErrorReportValve.java > [[[ > if (response.isCommitted()) { > if (response.isErrorAfterCommit()) { > // Flush any data that is still to be written to the client >

Re: Error handling

2014-06-06 Thread Konstantin Kolinko
2014-05-29 16:31 GMT+04:00 Mark Thomas : > You've probably noticed I've been poking around the ErrorReportValve, > the Response objects and other related code. I've been looking into an > issue that one of the groups at $work has raised around Tomcat's error > handling and I've been cleaning things

Re: Error handling

2014-06-02 Thread Mark Thomas
On 31/05/2014 14:57, Konstantin Kolinko wrote: > 2014-05-29 16:31 GMT+04:00 Mark Thomas : >> You've probably noticed I've been poking around the ErrorReportValve, >> the Response objects and other related code. I've been looking into an >> issue that one of the groups at $work has raised around Tom

Re: Error handling

2014-05-31 Thread Konstantin Kolinko
2014-05-29 16:31 GMT+04:00 Mark Thomas : > You've probably noticed I've been poking around the ErrorReportValve, > the Response objects and other related code. I've been looking into an > issue that one of the groups at $work has raised around Tomcat's error > handling and I've been cleaning things

Re: Error handling

2014-05-29 Thread Christopher Schultz
Mark, On 5/29/14, 8:31 AM, Mark Thomas wrote: > You've probably noticed I've been poking around the ErrorReportValve, > the Response objects and other related code. I've been looking into an > issue that one of the groups at $work has raised around Tomcat's error > handling and I've been cleaning

Re: Error handling

2014-05-29 Thread Mark Thomas
On 29/05/2014 16:54, Rémy Maucherat wrote: > 2014-05-29 14:31 GMT+02:00 Mark Thomas : > >> There are four variations: >> 1. Content length set, some content written, response not committed. >> 2. Content length set, some content written, response committed. >> 3. Content length not set, some conte

Re: Error handling

2014-05-29 Thread Rémy Maucherat
2014-05-29 14:31 GMT+02:00 Mark Thomas : > There are four variations: > 1. Content length set, some content written, response not committed. > 2. Content length set, some content written, response committed. > 3. Content length not set, some content written, response not committed. > 4. Content le