Re: Adding request/session valve to Tomcat

2015-10-29 Thread Milo van der Zee
Hello Chris, Thanks for pointing me to my mistake. I did not check InheritableThreadLocal functionality enough. In my usecase not an issue I think. With 'default' I do not mean 'enabled by default'. I mean that it is available in the classpath like the valves mentioned in https://tomcat.apache.or

Re: Adding request/session valve to Tomcat

2015-10-28 Thread Konstantin Kolinko
2015-10-28 23:03 GMT+03:00 Milo van der Zee : > Hello Chris, > > That is what I did but I expect a lot of people to have this problem. Seeing > a lot of default valves included I would like to also have this valve as > default. > > public class RequestValve extends ValveBase { > /** > * Se

Re: Adding request/session valve to Tomcat

2015-10-28 Thread Christopher Schultz
Milo, On 10/28/15 4:03 PM, Milo van der Zee wrote: > That is what I did but I expect a lot of people to have this problem. > Seeing a lot of default valves included I would like to also have this > valve as default. -1 Most applications don't need this. It's another layer of code that doesn't ne

Re: Adding request/session valve to Tomcat

2015-10-28 Thread Milo van der Zee
Hello Chris, That is what I did but I expect a lot of people to have this problem. Seeing a lot of default valves included I would like to also have this valve as default. public class RequestValve extends ValveBase { /** * Session for current thread. */ static InheritableTh

Re: Adding request/session valve to Tomcat

2015-10-28 Thread Christopher Schultz
Milo, On 10/28/15 4:12 AM, Milo van der Zee wrote: > With request I mean the 'org.apache.catalina.connector.Request' but this > implements 'javax.servlet.http.HttpServletRequest'. So, one and the same > thing for my situation. > And I don't only want access to that information during authenticatio

Re: Adding request/session valve to Tomcat

2015-10-28 Thread Milo van der Zee
Hello Chris, With request I mean the 'org.apache.catalina.connector.Request' but this implements 'javax.servlet.http.HttpServletRequest'. So, one and the same thing for my situation. And I don't only want access to that information during authentication but it can also be used to pass informat

Re: Adding request/session valve to Tomcat

2015-10-27 Thread Christopher Schultz
On 10/25/15 9:40 AM, Milo van der Zee wrote: > Hello, > > There are some default valves available with Tomcat. None of these > expose the request to later phases in the request cycle. Is it an idea > to add a valve that does this? And make this available through a > callback in the jaas loginMod