Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-23 Thread Christopher Schultz
Konstantin, On 11/23/15 7:19 AM, Konstantin Kolinko wrote: > 2015-11-22 22:26 GMT+03:00 Christopher Schultz : >> Konstantin, >> >> On 11/21/15 10:07 AM, Konstantin Kolinko wrote: >>> 2015-11-20 15:47 GMT+03:00 Christopher Schultz >>> : All, I thought there was a BZ issue for this,

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-23 Thread Konstantin Kolinko
2015-11-22 22:26 GMT+03:00 Christopher Schultz : > Konstantin, > > On 11/21/15 10:07 AM, Konstantin Kolinko wrote: >> 2015-11-20 15:47 GMT+03:00 Christopher Schultz >> : >>> All, >>> >>> I thought there was a BZ issue for this, but I didn't find one. It's >>> been suggested (and I agree completely

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-22 Thread Christopher Schultz
Konstantin, On 11/21/15 10:07 AM, Konstantin Kolinko wrote: > 2015-11-20 15:47 GMT+03:00 Christopher Schultz : >> All, >> >> I thought there was a BZ issue for this, but I didn't find one. It's >> been suggested (and I agree completely) that an application ought to be >> able to fetch the Credenti

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-21 Thread Konstantin Kolinko
2015-11-20 15:47 GMT+03:00 Christopher Schultz : > All, > > I thought there was a BZ issue for this, but I didn't find one. It's > been suggested (and I agree completely) that an application ought to be > able to fetch the CredentialHandler for the context's realm so that it > could mutate user cre

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Christopher Schultz
Mark, On 11/20/15 9:26 AM, Mark Thomas wrote: > On 20/11/2015 14:23, Mark Thomas wrote: >>> 2015-11-20 13:47 GMT+01:00 Christopher Schultz > > why does StandardContext.startInternal call getRealmInternal().start() when ContainerBase.setRealm already calls Realm.start()?) >> >> N

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Christopher Schultz
Mark, On 11/20/15 9:23 AM, Mark Thomas wrote: > On 20/11/2015 13:07, Rémy Maucherat wrote: >> 2015-11-20 13:47 GMT+01:00 Christopher Schultz >> : >> >>> All, >>> >>> I thought there was a BZ issue for this, but I didn't find one. It's >>> been suggested (and I agree completely) that an application

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Mark Thomas
On 20/11/2015 14:23, Mark Thomas wrote: >> 2015-11-20 13:47 GMT+01:00 Christopher Schultz >>> why does StandardContext.startInternal call >>> getRealmInternal().start() when ContainerBase.setRealm already calls >>> Realm.start()?) > > Not sure right now. I'll take a quick look. Because setRealm

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Rémy Maucherat
2015-11-20 15:17 GMT+01:00 Christopher Schultz : > Rémy, > > > > +1 for removing those pointless locks. > > Okay. I'm not going to remove those myself, though. If I don't hear from > anyone in a while, I'll commit my patch which always calls delegates to > getRealmInternal.getCredentialHandler.cal

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Mark Thomas
On 20/11/2015 13:07, Rémy Maucherat wrote: > 2015-11-20 13:47 GMT+01:00 Christopher Schultz > : > >> All, >> >> I thought there was a BZ issue for this, but I didn't find one. It's >> been suggested (and I agree completely) that an application ought to be >> able to fetch the CredentialHandler for

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Christopher Schultz
Rémy, On 11/20/15 8:07 AM, Rémy Maucherat wrote: > 2015-11-20 13:47 GMT+01:00 Christopher Schultz > : > >> All, >> >> I thought there was a BZ issue for this, but I didn't find one. It's >> been suggested (and I agree completely) that an application ought to be >> able to fetch the CredentialHand

Re: Adding CredentialHandler to ServletContext so applications can get to it

2015-11-20 Thread Rémy Maucherat
2015-11-20 13:47 GMT+01:00 Christopher Schultz : > All, > > I thought there was a BZ issue for this, but I didn't find one. It's > been suggested (and I agree completely) that an application ought to be > able to fetch the CredentialHandler for the context's realm so that it > could mutate user cr