Re: Access log changes in 7.0.6

2011-01-15 Thread Mark Thomas
On 14/01/2011 15:20, Konstantin Kolinko wrote: > The valve already implements AccessLog interface. > If we can turn AccessLogValve#invoke() into noop (pass-through) and > let the connector to provide us with logging via the #log(..) method, > I think that won't break compatibility. Neat. I have a

Re: Access log changes in 7.0.6

2011-01-14 Thread Christopher Schultz
Mark, On 1/14/2011 9:40 AM, Mark Thomas wrote: > c) Refactor the access logging. I don't have a clear picture of what > this might look like but I am thinking along the lines of: > - log to JULI rather than manage files in the access log -1 I think access logging is something where all configur

Re: Access log changes in 7.0.6

2011-01-14 Thread Konstantin Kolinko
2011/1/14 Mark Thomas : > The fix for bug 50496 [1] (response sizes in access log valve ignored > compression) was implemented by forcing the response to be flushed all > the way to the socket so the access log valve can get an accurate byte > count from the connector. > > This has a number of cons