Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-25 Thread Mark Thomas
On 24/01/2019 12:18, Rainer Jung wrote: > Am 21.01.2019 um 15:49 schrieb Mark Thomas: >> Version 1.2.20 includes the following changes compared to 1.2.19: >> >> - Fixed memory leak associated with the use of OpenSSL BIO (used when >>    OpenSSL provides the TLS functionality for the NIO and NIO2 >>

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-25 Thread Mark Thomas
On 24/01/2019 16:24, Mark Thomas wrote: > On 24/01/2019 15:22, Rainer Jung wrote: >> Checked in as 1852036. My tests looked good (no crashes), but it would >> be useful to rerun the original memleak checks against the patched code. > > Will do. I ran the tests for 2 hours / 35 million requests fo

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Mark Thomas
On 24/01/2019 15:22, Rainer Jung wrote: > Checked in as 1852036. My tests looked good (no crashes), but it would > be useful to rerun the original memleak checks against the patched code. Will do. Mark > > Regards, > > Rainer > > Am 24.01.2019 um 15:54 schrieb Rainer Jung: >> Am 24.01.2019 um

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Checked in as 1852036. My tests looked good (no crashes), but it would be useful to rerun the original memleak checks against the patched code. Regards, Rainer Am 24.01.2019 um 15:54 schrieb Rainer Jung: Am 24.01.2019 um 15:51 schrieb Rainer Jung: Am 24.01.2019 um 14:16 schrieb Mark Thomas:

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 15:51 schrieb Rainer Jung: Am 24.01.2019 um 14:16 schrieb Mark Thomas: On 24/01/2019 13:01, Rainer Jung wrote: Am 24.01.2019 um 13:37 schrieb Mark Thomas: It can happen in normal usage. I saw it once. It happens on Connector stop so it could be worse. My memory leak fix is

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 14:16 schrieb Mark Thomas: On 24/01/2019 13:01, Rainer Jung wrote: Am 24.01.2019 um 13:37 schrieb Mark Thomas: It can happen in normal usage. I saw it once. It happens on Connector stop so it could be worse. My memory leak fix is definitely the root cause. Any thoughts on a

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Mark Thomas
On 24/01/2019 13:01, Rainer Jung wrote: > Am 24.01.2019 um 13:37 schrieb Mark Thomas: >> It can happen in normal usage. I saw it once. It happens on Connector >> stop so it could be worse. My memory leak fix is definitely the root >> cause. Any thoughts on a possible fix? > > Currently experime

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 13:37 schrieb Mark Thomas: On 24/01/2019 12:18, Rainer Jung wrote: Am 21.01.2019 um 15:49 schrieb Mark Thomas: Version 1.2.20 includes the following changes compared to 1.2.19: - Fixed memory leak associated with the use of OpenSSL BIO (used when    OpenSSL provides the TLS f

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Mark Thomas
On 24/01/2019 12:18, Rainer Jung wrote: > Am 21.01.2019 um 15:49 schrieb Mark Thomas: >> Version 1.2.20 includes the following changes compared to 1.2.19: >> >> - Fixed memory leak associated with the use of OpenSSL BIO (used when >>    OpenSSL provides the TLS functionality for the NIO and NIO2 >>

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rémy Maucherat
On Thu, Jan 24, 2019 at 1:29 PM Rainer Jung wrote: > Am 21.01.2019 um 15:49 schrieb Mark Thomas: > > Version 1.2.20 includes the following changes compared to 1.2.19: > > > > - Fixed memory leak associated with the use of OpenSSL BIO (used when > >OpenSSL provides the TLS functionality for th

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 21.01.2019 um 15:49 schrieb Mark Thomas: Version 1.2.20 includes the following changes compared to 1.2.19: - Fixed memory leak associated with the use of OpenSSL BIO (used when OpenSSL provides the TLS functionality for the NIO and NIO2 connectors) Various other fixes and improvements.

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
I added some debug logging to native and the Java classes and the picture looks understandable now. Here the example from NIO and TestCustomSsl: - test testCustomTrustManagerNone creates OpenSSLEngine 7f560c39, ssl 4298850656 and con->pool 4309969128 from parent pool aprPool = c->pool 4306893

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 11:17 schrieb Rémy Maucherat: On Thu, Jan 24, 2019 at 10:49 AM Rainer Jung wrote: The other possibility - since the crash often happens in the finalizer - that there is double destruction between normal code and finalizer code. OpenSSLEngine.shutdown is obviously very risky

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 11:09 schrieb Mark Thomas: Thanks Rainer. This is all very helpful. I agree that r1851094 is the most likely cause. Unfortunately, I haven't been able to reproduce this reliably. Can you confirm APR and OpenSSL versions you used? APR 1.6.5 OpenSSL 1.0.2q In "java/org/apache/to

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rémy Maucherat
On Thu, Jan 24, 2019 at 10:49 AM Rainer Jung wrote: > The other possibility - since the crash often happens in the > finalizer - that there is double destruction between normal code and > finalizer code. > OpenSSLEngine.shutdown is obviously very risky, and after some problems it is now fully sy

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Mark Thomas
Thanks Rainer. This is all very helpful. I agree that r1851094 is the most likely cause. Unfortunately, I haven't been able to reproduce this reliably. Can you confirm APR and OpenSSL versions you used? I'll leave the 1.2.20 vote open for now (in case we track the root cause elsewhere) but I expec

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Addition: - running the same tests just replacing tcnative 1.2.20 by 1.2.19 does not crash - running the same 1.2.20 test on Linux (SLES11) also crashes, but this time not in TestCustomSsl for NIO and NIO2, but instead a few TLS tests only NIO2: [junit] Test org.apache.tomcat.util.net.

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-23 Thread Rainer Jung
Am 21.01.2019 um 15:49 schrieb Mark Thomas: Version 1.2.20 includes the following changes compared to 1.2.19: - Fixed memory leak associated with the use of OpenSSL BIO (used when OpenSSL provides the TLS functionality for the NIO and NIO2 connectors) Various other fixes and improvements.

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-22 Thread Igal Sapir
On Tue, Jan 22, 2019 at 5:19 AM Mark Thomas wrote: > On 22/01/2019 04:13, Igal Sapir wrote: > > On Mon, Jan 21, 2019 at 6:49 AM Mark Thomas wrote: > > > > >> > >> The Apache Tomcat Native 1.2.20 release is > >> [X] Stable, go ahead and release > >> > > > > Built and Tested on Ubuntu 18.04 > >

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-22 Thread Mark Thomas
On 22/01/2019 04:13, Igal Sapir wrote: > On Mon, Jan 21, 2019 at 6:49 AM Mark Thomas wrote: > >> Version 1.2.20 includes the following changes compared to 1.2.19: >> >> - Fixed memory leak associated with the use of OpenSSL BIO (used when >> OpenSSL provides the TLS functionality for the NIO an

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-21 Thread Igal Sapir
On Mon, Jan 21, 2019 at 6:49 AM Mark Thomas wrote: > Version 1.2.20 includes the following changes compared to 1.2.19: > > - Fixed memory leak associated with the use of OpenSSL BIO (used when > OpenSSL provides the TLS functionality for the NIO and NIO2 > connectors) > > Various other fixes

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-21 Thread Mark Thomas
On 21/01/2019 14:49, Mark Thomas wrote: > Version 1.2.20 includes the following changes compared to 1.2.19: > > - Fixed memory leak associated with the use of OpenSSL BIO (used when > OpenSSL provides the TLS functionality for the NIO and NIO2 > connectors) > > Various other fixes and improve

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-21 Thread Rémy Maucherat
On Mon, Jan 21, 2019 at 3:49 PM Mark Thomas wrote: > Version 1.2.20 includes the following changes compared to 1.2.19: > > - Fixed memory leak associated with the use of OpenSSL BIO (used when > OpenSSL provides the TLS functionality for the NIO and NIO2 > connectors) > > Various other fixes