Re: [Tomcat6] Eclipse warnings

2009-12-18 Thread Pejus M. Das
-1 to fixing cosmetic changes for TC 6 (If I can vote that is. :). Filip has a good point and I concur. Thanks, Pejus On Thu, Dec 17, 2009 at 3:00 PM, Filip Hanik - Dev Lists wrote: > On 12/17/2009 08:38 AM, Mark Thomas wrote: > >> On 16/12/2009 21:31, sebb wrote: >> >> >>> Eclipse generates m

Re: [Tomcat6] Eclipse warnings

2009-12-17 Thread Filip Hanik - Dev Lists
On 12/17/2009 08:38 AM, Mark Thomas wrote: On 16/12/2009 21:31, sebb wrote: Eclipse generates many thousands of warnings for the Tomcat6 code. For example, over 2000 missing @Override markers, over 3000 "raw type" warnings. Is it the intention to fix these (eventually)? Speaking per

Re: [Tomcat6] Eclipse warnings

2009-12-17 Thread sebb
On 17/12/2009, Mark Thomas wrote: > On 16/12/2009 21:31, sebb wrote: > > Eclipse generates many thousands of warnings for the Tomcat6 code. > > > > For example, over 2000 missing @Override markers, over 3000 "raw type" > warnings. > > > > Is it the intention to fix these (eventually)? > > >

Re: [Tomcat6] Eclipse warnings

2009-12-17 Thread Mark Thomas
On 16/12/2009 21:31, sebb wrote: > Eclipse generates many thousands of warnings for the Tomcat6 code. > > For example, over 2000 missing @Override markers, over 3000 "raw type" > warnings. > > Is it the intention to fix these (eventually)? Speaking personally, I have no intention of spending an

Re: [Tomcat6] Eclipse warnings

2009-12-16 Thread Ian Darwin
On Thu, Dec 17, 2009 at 03:23:14AM +0300, Konstantin Kolinko wrote: > I think that adding @Override or generics to the existing API is, > at least formally, an API change, and thus TC 7 is the right place to fix it. @Override is just a compile time annotation to check the override status, so I'm n

Re: [Tomcat6] Eclipse warnings

2009-12-16 Thread sebb
On 17/12/2009, Konstantin Kolinko wrote: > 2009/12/16 sebb : > > > Eclipse generates many thousands of warnings for the Tomcat6 code. > > > > For example, over 2000 missing @Override markers, over 3000 "raw type" > warnings. > > > > Is it the intention to fix these (eventually)? > > > > If

Re: [Tomcat6] Eclipse warnings

2009-12-16 Thread Konstantin Kolinko
2009/12/16 sebb : > Eclipse generates many thousands of warnings for the Tomcat6 code. > > For example, over 2000 missing @Override markers, over 3000 "raw type" > warnings. > > Is it the intention to fix these (eventually)? > > If so, I can provide some patches to start fixing these. Mark worked