Dmole commented on PR #814:
URL: https://github.com/apache/tomcat/pull/814#issuecomment-2678622306
https://github.com/apache/tomcat/commit/3cfc9bc048109c5a566fc24539e5bb9759c114b6
https://github.com/apache/tomcat/commit/987f737afe4f08da939d870b5b1ec4b96010d926
--
This is an automa
markt-asf commented on PR #814:
URL: https://github.com/apache/tomcat/pull/814#issuecomment-2678517529
Manually applied as there were a few things I needed to add/change
- %{xxx}L is for ID attributes not connection attributes
- new settings needed to be added to the docs
- change lo
markt-asf closed pull request #814: log connectionId
URL: https://github.com/apache/tomcat/pull/814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-
Dmole commented on PR #814:
URL: https://github.com/apache/tomcat/pull/814#issuecomment-2663891024
Add %{c}L and x-H(connectionId) to AccessLogValve and ExtendedAccessLogValve
to cross reference errors from catalina.log
--
This is an automated message from the Apache Git Service.
To respo
rainerjung commented on PR #814:
URL: https://github.com/apache/tomcat/pull/814#issuecomment-2663481464
Concerning analogies in Apache httpd land:
ErrorLogFormat has
```
%{c}LLog ID of the connection
%{C}LLog ID of the connection if used in connection scope
markt-asf commented on PR #814:
URL: https://github.com/apache/tomcat/pull/814#issuecomment-2663380820
That looks good for for the `ExtendedAccessLogValve`.
I don't like that this is automatically added as a request attribute.
Firstly, if we add this field, why not all the others? Sec
Dmole commented on PR #814:
URL: https://github.com/apache/tomcat/pull/814#issuecomment-2631971994
I added it to both AccessLogValve and ExtendedAccessLogValve because it is
non-trivial for users to switch between them as the documentation does not
provide a mapping (EG: %v = ?), and the ex
markt-asf commented on PR #814:
URL: https://github.com/apache/tomcat/pull/814#issuecomment-2630509072
This is not the way to do this. Look at the ExtendedAccessLogValve. Look at
`x-H(...)` options.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
