Re: [PR] Add unit tests for AsyncStateMachine's asyncPostProcess method [tomcat]

2025-03-08 Thread via GitHub
koust6u closed pull request #828: Add unit tests for AsyncStateMachine's asyncPostProcess method URL: https://github.com/apache/tomcat/pull/828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Add unit tests for AsyncStateMachine's asyncPostProcess method [tomcat]

2025-02-25 Thread via GitHub
koust6u commented on PR #828: URL: https://github.com/apache/tomcat/pull/828#issuecomment-2681419698 Thank you for your valuable feedback and for providing the coverage report link. I appreciate your insights on improving test coverage. I'll review the uncovered code paths and work on addin

Re: [PR] Add unit tests for AsyncStateMachine's asyncPostProcess method [tomcat]

2025-02-24 Thread via GitHub
rmaucher commented on PR #828: URL: https://github.com/apache/tomcat/pull/828#issuecomment-2677710733 BTW, the code coverage report is here: https://nightlies.apache.org/tomcat/tomcat-12.0.x/coverage/index.html#dn-a It can be generated using test.coverage=true property in build.properties

Re: [PR] Add unit tests for AsyncStateMachine's asyncPostProcess method [tomcat]

2025-02-24 Thread via GitHub
markt-asf commented on PR #828: URL: https://github.com/apache/tomcat/pull/828#issuecomment-2677681461 The code coverage of `AsyncStateMachine` is already fairly good. I'd prefer to see some tests using real requests that exercised the few code paths (excluding trace level logging and `Ille

Re: [PR] Add unit tests for AsyncStateMachine's asyncPostProcess method [tomcat]

2025-02-16 Thread via GitHub
dsoumis commented on PR #828: URL: https://github.com/apache/tomcat/pull/828#issuecomment-2661457556 1) Please ensure that you run ant validate or use Checkstyle tool with the checkstyle rules provided before submitting a PR. There are currently some checkstyle errors in your import stateme