RE: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java

2013-01-17 Thread Caldarale, Charles R
> From: Mark Thomas [mailto:ma...@apache.org] > Subject: Re: svn commit: r1434905 - > /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java > I did see a "no unnecessary brackets" rule that I think Chuck would love. My favorite hate is multi-line if statements without br

Re: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java

2013-01-17 Thread Mark Thomas
On 17/01/2013 22:49, Christopher Schultz wrote: > On 1/17/13 4:28 PM, Mark Thomas wrote: >> I have Checkstyle configured in Eclipse and it nags me if it >> finds any trailing whitespace (usually from other commits after >> an svn up). > > I'll work on getting that configured, too. You might

Re: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java

2013-01-17 Thread Christopher Schultz
Mark, On 1/17/13 4:28 PM, Mark Thomas wrote: > On 17/01/2013 21:07, Christopher Schultz wrote: >> Mark, >> >> On 1/17/13 3:41 PM, ma...@apache.org wrote: >>> Author: markt Date: Thu Jan 17 20:41:19 2013 New Revision: >>> 1434905 >>> >>> URL: http://svn.apache.org/viewvc?rev=1434905&view=rev Log:

Re: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java

2013-01-17 Thread Mark Thomas
On 17/01/2013 21:07, Christopher Schultz wrote: > Mark, > > On 1/17/13 3:41 PM, ma...@apache.org wrote: >> Author: markt Date: Thu Jan 17 20:41:19 2013 New Revision: >> 1434905 >> >> URL: http://svn.apache.org/viewvc?rev=1434905&view=rev Log: >> Trailing whitespace police > > Do you have any id

RE: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java

2013-01-17 Thread Caldarale, Charles R
> From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Subject: Re: svn commit: r1434905 - > /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java > Do you have any idea how to get Eclipse to stop adding that crap? It's > obviously impossible to see and running

Re: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java

2013-01-17 Thread Christopher Schultz
Mark, On 1/17/13 3:41 PM, ma...@apache.org wrote: > Author: markt > Date: Thu Jan 17 20:41:19 2013 > New Revision: 1434905 > > URL: http://svn.apache.org/viewvc?rev=1434905&view=rev > Log: > Trailing whitespace police Do you have any idea how to get Eclipse to stop adding that crap? It's obvious