RE: Writing unit tests

2010-09-20 Thread Caldarale, Charles R
> From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Subject: Re: Writing unit tests > > Yep. Go with the current style of the file. > Gotcha. Just remember: no bloody tabs (even if the source file still has some). - Chuck THIS COMMUNICATION MAY CONTAIN CONF

Re: Writing unit tests

2010-09-20 Thread Christopher Schultz
Mark, On 9/20/2010 4:52 PM, Mark Thomas wrote: > That'll probably be better in 7.0.x. I do wonder what init code you > might need. I was expecting a simple boolean attribute. Once that is > sorted, we can figure out how to port it to 6.0.x Since I was thinking of allowing any set of HTTP methods,

Re: Writing unit tests

2010-09-20 Thread Mark Thomas
On 20/09/2010 13:46, Christopher Schultz wrote: > 1. There's a method in catalina.connector.Connector called init(). When > does that get called? I had expected that it would be called after all > the setXXX attributes had be set on it from the digester upon start-up, > but it appears that Connect

Re: Writing unit tests

2010-09-20 Thread Christopher Schultz
Mark, On 9/20/2010 4:33 PM, Mark Thomas wrote: > On 20/09/2010 11:29, Christopher Schultz wrote: >> All, >> >> I'm attempting a patch for >> https://issues.apache.org/bugzilla/show_bug.cgi?id=49964 and I'd like to >> write a few unit tests for it. In the Tomcat 6.0.x trunk, I can only >> find what

Re: Writing unit tests

2010-09-20 Thread Mark Thomas
On 20/09/2010 11:29, Christopher Schultz wrote: > All, > > I'm attempting a patch for > https://issues.apache.org/bugzilla/show_bug.cgi?id=49964 and I'd like to > write a few unit tests for it. In the Tomcat 6.0.x trunk, I can only > find what appear to be 30-40 test files. Is there a test suite e