Re: JarScanning

2013-03-29 Thread Nick Williams
On Mar 29, 2013, at 12:57 PM, Konstantin Kolinko wrote: > 2013/3/29 Nick Williams : >> >> >> (..) Note that Log4j2 is going to have a log4j-taglib artifact that >> (naturally) will have a TLD in its META-INF. Since Tomcat by default >> excludes log4j*.jar, that has to be removed from catalina

Re: JarScanning

2013-03-29 Thread Konstantin Kolinko
2013/3/29 Nick Williams : > > > (..) Note that Log4j2 is going to have a log4j-taglib artifact that > (naturally) will have a TLD in its META-INF. Since Tomcat by default excludes > log4j*.jar, that has to be removed from catalina.properties in order to make > it work. It would be great for Tomc

Re: JarScanning

2013-03-28 Thread Nick Williams
On Feb 26, 2013, at 11:21 AM, Christopher Schultz wrote: > Mark, > > On 2/21/13 8:34 AM, Mark Thomas wrote: >> JRE JARs. >> I think scanning of these should be made optional and disabled by >> default. This will reduce the list of JARs we have to maintain in >> jarsToSkip. I intend to implement

Re: JarScanning

2013-02-26 Thread Christopher Schultz
Mark, On 2/21/13 8:34 AM, Mark Thomas wrote: > JRE JARs. > I think scanning of these should be made optional and disabled by > default. This will reduce the list of JARs we have to maintain in > jarsToSkip. I intend to implement this unless there are any objections. +1 Will you be checking the C

Re: JarScanning

2013-02-22 Thread Konstantin Kolinko
2013/2/21 Mark Thomas : > An issue at work prompted me to take another look at this thread: > http://markmail.org/thread/qanw2psjsx32feek > > There are some useful things there that I think it is worth following up on. > >(..) > > jarsToScan > This is a little more complicated. > First of all, how

Re: JarScanning

2013-02-21 Thread Nick Williams
On Feb 21, 2013, at 10:42 AM, Romain Manni-Bucau wrote: > Hi, > > the best IMO would be to have a WEB-INF/tomcat.properties with the ability > to configure the scanner + its properties (thanks a prefix) from the webapp > itself > > PS: META-INF/context.xml would work too but i'm not a fan of xm

Re: JarScanning

2013-02-21 Thread Rainer Jung
On 21.02.2013 17:34, Mark Thomas wrote: > An issue at work prompted me to take another look at this thread: > http://markmail.org/thread/qanw2psjsx32feek > > There are some useful things there that I think it is worth following up on. > > JRE JARs. > I think scanning of these should be made optio

RE: JarScanning

2013-02-21 Thread Caldarale, Charles R
> From: Mark Thomas [mailto:ma...@apache.org] > Subject: Re: JarScanning > > From the above, it looks like the only purpose of jarsToScan is to > > avoid checking the jarsToSkip list. Unless such checking is > > expensive, this seems like an unnecessary complication.

Re: JarScanning

2013-02-21 Thread Mark Thomas
On 21/02/2013 16:39, Caldarale, Charles R wrote: >> From: Mark Thomas [mailto:ma...@apache.org] Subject: JarScanning > >> jarsToScan This is a little more complicated. First of all, how >> does it work? The suggestion is: - If jarsToScan matches, scan it - >> else if jarsToSkip matches, skip it -

Re: JarScanning

2013-02-21 Thread Romain Manni-Bucau
Hi, the best IMO would be to have a WEB-INF/tomcat.properties with the ability to configure the scanner + its properties (thanks a prefix) from the webapp itself PS: META-INF/context.xml would work too but i'm not a fan of xml ;) *Romain Manni-Bucau* *Twitter: @rmannibucau

RE: JarScanning

2013-02-21 Thread Caldarale, Charles R
> From: Mark Thomas [mailto:ma...@apache.org] > Subject: JarScanning > jarsToScan > This is a little more complicated. > First of all, how does it work? The suggestion is: > - If jarsToScan matches, scan it > - else if jarsToSkip matches, skip it > - else scan it >From the above, it looks like t