Re: Proposed patch for JDTCompiler

2014-05-13 Thread Christopher Schultz
Rémy, On 5/7/14, 9:33 AM, Rémy Maucherat wrote: > 2014-05-06 19:25 GMT+02:00 Christopher Schultz > : > >> >> Since this is not really a "bug" per se, I decided not to create a BZ >> issue. If it would be easier for everyone if I attached the patch to a >> BZ issue I'm happy to do that as well. >>

Re: Proposed patch for JDTCompiler

2014-05-10 Thread Rémy Maucherat
2014-05-06 19:25 GMT+02:00 Christopher Schultz : > > Since this is not really a "bug" per se, I decided not to create a BZ > issue. If it would be easier for everyone if I attached the patch to a > BZ issue I'm happy to do that as well. > Ok, but this is not a review then commit branch, so you ca

Proposed patch for JDTCompiler

2014-05-06 Thread Christopher Schultz
All, Konstantin Kolinko pointed out that some code in the JDTCompiler was particularly ugly, so I took a shot at improving it. Unfortunately, I don't have much experience with that component so I didn't want to commit anything. Can I get a review on this patch? I'm basically just replacing strin