Re: PROPOSAL: Update Tomcat 7 tests to JUnit 4

2011-07-25 Thread Konstantin Kolinko
2011/7/26 Konstantin Kolinko : > 2011/7/22 Konstantin Kolinko : >> * First step is to use these values in build.properties: >> * Next step is to convert existing tests to use JUnit 4 annotations. >> > > Completed for everything, > except test cases that are in org.apache.catalina.tribes.**. I have

Re: PROPOSAL: Update Tomcat 7 tests to JUnit 4

2011-07-25 Thread Konstantin Kolinko
2011/7/22 Konstantin Kolinko : > * First step is to use these values in build.properties: > > junit.home=${base.path}/junit4.8.2 > junit.lib=${junit.home} > junit.jar=${junit.lib}/junit-4.8.2.jar > junit.loc=http://cloud.github.com/downloads/KentBeck/junit/junit4.8.2.zip > > With this, all our test

Re: PROPOSAL: Update Tomcat 7 tests to JUnit 4

2011-07-25 Thread Christoph Pater
Ok I will start to look at org.apache.catalina.tribes.* tests 2011/7/25 Konstantin Kolinko > 2011/7/22 Konstantin Kolinko : > > Hi! > > > > I propose to update Tomcat 7 tests to use JUnit 4. > > > > One feature that I would like to use from there is to write failing > > tests before fixing the c

Re: PROPOSAL: Update Tomcat 7 tests to JUnit 4

2011-07-25 Thread Konstantin Kolinko
2011/7/22 Konstantin Kolinko : > Hi! > > I propose to update Tomcat 7 tests to use JUnit 4. > > One feature that I would like to use from there is to write failing > tests before fixing the code and annotate them with @Ignore so that > they are skipped until the annotation is removed. > > > * First

Re: PROPOSAL: Update Tomcat 7 tests to JUnit 4

2011-07-23 Thread Christoph Pater
I like that idea. I'm new to tomcat sources but maybe I can volunteer here? 2011/7/22 Ian Darwin > > > Are there any objections or comments? > > Go for it! JUnit 4.x has been out and stable for like a hundred years > now :-). > > --

Re: PROPOSAL: Update Tomcat 7 tests to JUnit 4

2011-07-22 Thread Ian Darwin
> Are there any objections or comments? Go for it! JUnit 4.x has been out and stable for like a hundred years now :-). - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.

PROPOSAL: Update Tomcat 7 tests to JUnit 4

2011-07-22 Thread Konstantin Kolinko
Hi! I propose to update Tomcat 7 tests to use JUnit 4. One feature that I would like to use from there is to write failing tests before fixing the code and annotate them with @Ignore so that they are skipped until the annotation is removed. * First step is to use these values in build.propertie