Re: Opportunities for cohesion improvement and refatoring

2017-08-14 Thread Christopher Schultz
João Paulo, On 8/4/17 1:52 PM, João Paulo Lemes Machado wrote: > 2017-08-02 17:41 GMT-03:00 Christopher Schultz > : > > Mark and João, > > On 8/2/17 3:38 AM, Mark Thomas wrote: On 02/08/2017 00:02, João Paulo Lemes Machado wrote: > Hi Mark. > > Did you take a look at my suggesti

Re: Opportunities for cohesion improvement and refatoring

2017-08-04 Thread João Paulo Lemes Machado
Hi Christopher thank you for the comment. Sorry I did not understand. What do you mean by Fluent? 2017-08-02 17:41 GMT-03:00 Christopher Schultz : > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Mark and João, > > On 8/2/17 3:38 AM, Mark Thomas wrote: > > On 02/08/2017 00:02, João Paulo

Re: Opportunities for cohesion improvement and refatoring

2017-08-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark and João, On 8/2/17 3:38 AM, Mark Thomas wrote: > On 02/08/2017 00:02, João Paulo Lemes Machado wrote: >> Hi Mark. >> >> Did you take a look at my suggestion? > > Yes. I don't think the cost is worth the benefit. +1 So what if the class has

Re: Opportunities for cohesion improvement and refatoring

2017-08-02 Thread Mark Thomas
On 02/08/17 20:18, João Paulo Lemes Machado wrote: > When you talk about the cost, do you mean backward compatibility? The time taken to do it, the duplicated code until the deprecated code can be removed, the cost of downstream users updating their code. All for a minimal maintenance benefit. O

Re: Opportunities for cohesion improvement and refatoring

2017-08-02 Thread João Paulo Lemes Machado
When you talk about the cost, do you mean backward compatibility? 2017-08-02 4:38 GMT-03:00 Mark Thomas : > On 02/08/2017 00:02, João Paulo Lemes Machado wrote: > > Hi Mark. > > > > Did you take a look at my suggestion? > > Yes. I don't think the cost is worth the benefit. > > Mark > > > > > > 2

Re: Opportunities for cohesion improvement and refatoring

2017-08-02 Thread Mark Thomas
On 02/08/2017 00:02, João Paulo Lemes Machado wrote: > Hi Mark. > > Did you take a look at my suggestion? Yes. I don't think the cost is worth the benefit. Mark > > 2017-07-25 15:33 GMT-03:00 João Paulo Lemes Machado > : > >> Hi Mark, tanks for the comment. >> >> Let me take the DataSourceP

Re: Opportunities for cohesion improvement and refatoring

2017-08-01 Thread João Paulo Lemes Machado
Hi Mark. Did you take a look at my suggestion? 2017-07-25 15:33 GMT-03:00 João Paulo Lemes Machado : > Hi Mark, tanks for the comment. > > Let me take the DataSourceProxy as example. > > This class has 142 methods of which 112 are get () and set () methods. > We could mark these methods as dep

Re: Opportunities for cohesion improvement and refatoring

2017-07-25 Thread João Paulo Lemes Machado
Hi Mark, tanks for the comment. Let me take the DataSourceProxy as example. This class has 142 methods of which 112 are get () and set () methods. We could mark these methods as deprecated and copy them to a new class: DataSourceProxyConfig, but we would leave them in the DataSourceProxy class,

Re: Opportunities for cohesion improvement and refatoring

2017-07-25 Thread Mark Thomas
On 25/07/17 13:55, João Paulo Lemes Machado wrote: > Hello everyone. > > My name is João Paulo, I am a graduate student the Federal University of > Uberlandia, Brazil. > > I was analyzing the modularization of some classes of Tomcat, and I > identified some opportunities for cohesion improvement

Opportunities for cohesion improvement and refatoring

2017-07-25 Thread João Paulo Lemes Machado
Hello everyone. My name is João Paulo, I am a graduate student the Federal University of Uberlandia, Brazil. I was analyzing the modularization of some classes of Tomcat, and I identified some opportunities for cohesion improvement in the following classes: DataSourceProxy ConnectionPool BasicD