Re: Notes from review of BZ 56029 and ELParser patches

2014-01-21 Thread Mark Thomas
On 21/01/2014 04:14, Konstantin Kolinko wrote: > Hi! > > Reviewing the patches for > https://issues.apache.org/bugzilla/show_bug.cgi?id=56029 > (r1559555, r1559708, r1559820) Thanks for the review. I'm really beginning to dislike this code ;) I'll take a look at the individual issues asap. As a

Notes from review of BZ 56029 and ELParser patches

2014-01-20 Thread Konstantin Kolinko
Hi! Reviewing the patches for https://issues.apache.org/bugzilla/show_bug.cgi?id=56029 (r1559555, r1559708, r1559820) Important: 1. The test "org.apache.jasper.compiler.TestELParser" tests success of a roundtrip: - parsing a String into EL expression - recreating original String with ELP