[GitHub] [tomcat] thomasmey commented on pull request #539: JsonAccessLogValve: Add valve for structured logging

2023-04-27 Thread via GitHub
thomasmey commented on PR #539: URL: https://github.com/apache/tomcat/pull/539#issuecomment-1525602662 @rainerjung very nice, many thanks! I just did test the version which landed in 9.0.74 ... I will allocate some time next week and do some tests. As you are also an http

[GitHub] [tomcat] rainerjung commented on pull request #539: JsonAccessLogValve: Add valve for structured logging

2023-04-27 Thread via GitHub
rainerjung commented on PR #539: URL: https://github.com/apache/tomcat/pull/539#issuecomment-1525194171 @thomasmey I added support for all subkeyed patterns like request headers (%i), response headers (%o) etc. You might want to have a look and test it. It is now contained in the heads for

[tomcat] branch 8.5.x updated: Improve JsonAccessLogValve: support more patterns like for headers and attributes.

2023-04-27 Thread rjung
This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 5f010ee726 Improve JsonAccessLogValve: support

[tomcat] branch 9.0.x updated: Improve JsonAccessLogValve: support more patterns like for headers and attributes.

2023-04-27 Thread rjung
This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 76f43275c7 Improve JsonAccessLogValve: support

[tomcat] branch 10.1.x updated: Improve JsonAccessLogValve: support more patterns like for headers and attributes.

2023-04-27 Thread rjung
This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new c95e5a3f92 Improve JsonAccessLogValve: support

[tomcat] branch main updated: Improve JsonAccessLogValve: support more patterns like for headers and attributes.

2023-04-27 Thread rjung
This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 26c55d239e Improve JsonAccessLogValve: support more

[tomcat] branch 8.5.x updated: Remove redundant Json escaping of values in JsonAccessLogValve.

2023-04-27 Thread rjung
values in JsonAccessLogValve. 0d658cac82 is described below commit 0d658cac8259ade2ed8dc25bb93931c15838cd9d Author: Rainer Jung AuthorDate: Thu Apr 27 10:29:23 2023 +0200 Remove redundant Json escaping of values in JsonAccessLogValve. The value escaping done in AbstractAccessLogValve is

[tomcat] branch 9.0.x updated: Remove redundant Json escaping of values in JsonAccessLogValve.

2023-04-27 Thread rjung
values in JsonAccessLogValve. 098de46890 is described below commit 098de4689073e2ef71bba08139239cb6fe4abff6 Author: Rainer Jung AuthorDate: Thu Apr 27 10:28:59 2023 +0200 Remove redundant Json escaping of values in JsonAccessLogValve. The value escaping done in AbstractAccessLogValve is

[tomcat] branch 10.1.x updated: Remove redundant Json escaping of values in JsonAccessLogValve.

2023-04-27 Thread rjung
values in JsonAccessLogValve. 511ca79028 is described below commit 511ca7902810d6d3b2b8457151bb66f2b57a4c3a Author: Rainer Jung AuthorDate: Thu Apr 27 10:28:28 2023 +0200 Remove redundant Json escaping of values in JsonAccessLogValve. The value escaping done in AbstractAccessLogValve

[tomcat] branch main updated: Remove redundant Json escaping of values in JsonAccessLogValve.

2023-04-27 Thread rjung
in JsonAccessLogValve. b3294ebe45 is described below commit b3294ebe45dbe4eeda7b112e5c52c0c89e50c1c9 Author: Rainer Jung AuthorDate: Thu Apr 27 10:28:07 2023 +0200 Remove redundant Json escaping of values in JsonAccessLogValve. The value escaping done in AbstractAccessLogValve is

Re: JsonAccessLogValve

2023-04-24 Thread Rémy Maucherat
On Fri, Apr 21, 2023 at 7:15 PM Rainer Jung wrote: > > Hi all, > > I am looking at the new access log valve to add support for the pattern > fields with sub keys (headers, attributes etc.). Note: The valve uses the regular AccessLogValve. It could use ExtendedAccessLogValve instead, but I preferr

JsonAccessLogValve

2023-04-21 Thread Rainer Jung
Hi all, I am looking at the new access log valve to add support for the pattern fields with sub keys (headers, attributes etc.). Many of those have free text values, so ensuring correct encodig is important. I noticed, that the AbstractAccessLogValve already does almost correct JSON encoding

[GitHub] [tomcat] rmaucher closed pull request #539: JsonAccessLogValve: Add valve for structured logging

2023-03-03 Thread via GitHub
rmaucher closed pull request #539: JsonAccessLogValve: Add valve for structured logging URL: https://github.com/apache/tomcat/pull/539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tomcat] rmaucher commented on pull request #539: JsonAccessLogValve: Add valve for structured logging

2023-03-03 Thread via GitHub
rmaucher commented on PR #539: URL: https://github.com/apache/tomcat/pull/539#issuecomment-1453257058 I merged this with significant modifications. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] thomasmey opened a new pull request, #539: JsonAccessLogValve: Add valve for structured logging

2022-08-14 Thread GitBox
thomasmey opened a new pull request, #539: URL: https://github.com/apache/tomcat/pull/539 Hi, this adds a AccessLogValve which logs to stderr in JSON format. sadly the existing code is very entagled in this regards, that the AccessLogElement does cover two functions: formatting