Re: Fix #43236

2008-03-05 Thread Mark Thomas
Jess Holle wrote: On the other hand, the servlet spec seems to state fairly unequivocally that (1) and (2) should result in IllegalStateExceptions and in (3) the setCharacterEncoding() call should be silently ignored. I'm not arguing for the fix to be rolled back, but I am trying to get some

Re: Fix #43236

2008-03-05 Thread Jess Holle
P.S. Thanks for the reply. No one had responded yet and I despite much googling I really couldn't seem to find any discussion of the nuances of this area of the servlet spec. Jess Holle wrote: Leech, Jonathan wrote: I read the spec the same way as you do. I have written filters that are even

Re: Fix #43236

2008-03-05 Thread Jess Holle
Leech, Jonathan wrote: I read the spec the same way as you do. I have written filters that are even more permissive than this fix, and I have also written filters that strictly adhere to the spec. Strictly adhering to the spec is definitely the way to go. If you want/need your application to vi

RE: Fix #43236

2008-03-05 Thread Leech, Jonathan
write a filter that allows it. I wasn't aware that you can call getOutputStream() in a JSP, when did that change? -Jonathan -Original Message- From: Jess Holle [mailto:[EMAIL PROTECTED] Sent: Tuesday, March 04, 2008 6:15 PM To: Tomcat Developers List Subject: Fix #43236 I bela

Fix #43236

2008-03-04 Thread Jess Holle
I belatedly noticed this bug fix in 5.5.26 and 6.0.16. On the one hand this seems like a nice fix, allowing the following call sequences on ServletResponse: 1. getWriter(), reset(), and then getOutputStream() 2. getOutputStream(), reset(), and then getWriter() 3. getWriter(), reset(), se