Re: Feature: Tomcat queue waiting time

2024-12-04 Thread Mark Thomas
On 03/12/2024 03:37, Owner wrote: Hey Mark, Thank you for the input. I believe that such a feature will be extremely helpful as well, on top of the queue time. 1. I was thinking - if we want to accurately capture the time taken by the Poller (only the poller, which excludes the time taken after

Re: Feature: Tomcat queue waiting time

2024-12-02 Thread Owner
Hey Mark, Thank you for the input. I believe that such a feature will be extremely helpful as well, on top of the queue time. 1. I was thinking - if we want to accurately capture the time taken by the Poller (only the poller, which excludes the time taken after accepting connections.) in reading

Re: Feature: Tomcat queue waiting time

2024-12-02 Thread Mark Thomas
Andy, I think you are missing a chunk of time with this approach. I'd look at recording time on the SocketWrapper when the connection is accepted. Or at least something along those lines. I haven;t looked too carefully at the code to see what might be possible. That way you'll also capture the

Re: Feature: Tomcat queue waiting time

2024-12-02 Thread Owner
Hi Mark, Apologies for sending you an email again, could I ask for a quick review on how I made this feature work to see if I have any misconceptions, which could affect how I would code it in Tomcat's source code? On top of the queue time, I added the request processing time as well as I wanted t

Re: Feature: Tomcat queue waiting time

2024-11-28 Thread Owner
Hey Mark, Thank you for your response. I've actually developed it on my own Spring Boot Application to scrape these metrics, but it involves subclassing TaskQueue (in order to overwrite the offer() method and track the start/end time), and utilising this subclassed queue when constructing my Execu

Re: Feature: Tomcat queue waiting time

2024-11-28 Thread Mark Thomas
On 28/11/2024 09:26, Owner wrote: Hi Tomcat Devs, Hope you guys are having a great day. I'm a new developer to this area so do let me know if I have any misconceptions or errors in my thinking. I am currently using Tomcat as an embedded web server within a Spring Boot Application, and I utilise

Feature: Tomcat queue waiting time

2024-11-28 Thread Owner
Hi Tomcat Devs, Hope you guys are having a great day. I'm a new developer to this area so do let me know if I have any misconceptions or errors in my thinking. I am currently using Tomcat as an embedded web server within a Spring Boot Application, and I utilise Micrometer to expose Tomcat metrics