Re: Duplicate code in AccessLogValve

2009-06-19 Thread sebb
etimes create a new Date unecessarily. > > > 2009/6/19 sebb > > > > On 19/06/2009, sebb wrote: > > > Just spotted this duplicate code in AccessLogValve: > > > > > > 661:if (!dateStamp.equals(tsDate)) { &

Re: Duplicate code in AccessLogValve

2009-06-19 Thread Xie Xiaodong
No, I think line767 is still needed. You could turn to the last part of this article for reference: " http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html";. 2009/6/19 sebb > On 19/06/2009, sebb wrote: > > Just spotted this duplicate code in AccessLog

Re: Duplicate code in AccessLogValve

2009-06-19 Thread sebb
On 19/06/2009, sebb wrote: > Just spotted this duplicate code in AccessLogValve: > > 661:if (!dateStamp.equals(tsDate)) { > 662:if (!dateStamp.equals(tsDate)) { > > Not sure this double-checked looking offers any benefit

Duplicate code in AccessLogValve

2009-06-19 Thread sebb
Just spotted this duplicate code in AccessLogValve: 661:if (!dateStamp.equals(tsDate)) { 662:if (!dateStamp.equals(tsDate)) { Not sure this double-checked looking offers any benefit