Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Christopher Schultz
Rainer, On 7/10/2011 3:38 PM, Rainer Jung wrote: > Unfortunately I stumbled into some code in StandardSession: > > public void setAttribute(String name, Object value, boolean notify) { > ... > if ((manager != null) && manager.getDistributable() && > !(value instanceof Serializable)) > throw

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Mark Thomas
On 11/07/2011 14:50, Rainer Jung wrote: > On 10.07.2011 23:11, Filip Hanik - Dev Lists wrote: >> go ahead add it in, if you add in a flag to toggle the behavior, and the >> flag is defaulted to today's behavior. you're safe, and you give users >> an option > > Thanks for the feedback. I will go wi

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Rainer Jung
On 11.07.2011 13:41, Konstantin Kolinko wrote: > 2011/7/10 Rainer Jung : >> >> I think checking for serializability in StandardSession isn't good, >> because AFAIK StandardSession isn't used by any mechanism Tomcat >> supports to implement "distributable". >> >> And in DeltaSession I would like to

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Rainer Jung
On 10.07.2011 23:11, Filip Hanik - Dev Lists wrote: > go ahead add it in, if you add in a flag to toggle the behavior, and the > flag is defaulted to today's behavior. you're safe, and you give users > an option Thanks for the feedback. I will go with Konstantin's suggestion of making it overwrita

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Konstantin Kolinko
2011/7/10 Rainer Jung : > I implemented an addition to DeltaManager which allows to filter which > session attributes actually get replicated (not yet committed). > > This is useful, because many applications > > - use non-serializable session attributes, so >  it is not possible to simply replicat

Re: Distributable contexts and non-serializable session attributes

2011-07-10 Thread Filip Hanik - Dev Lists
go ahead add it in, if you add in a flag to toggle the behavior, and the flag is defaulted to today's behavior. you're safe, and you give users an option Filip On 7/10/2011 1:38 PM, Rainer Jung wrote: I implemented an addition to DeltaManager which allows to filter which session attributes act

Distributable contexts and non-serializable session attributes

2011-07-10 Thread Rainer Jung
I implemented an addition to DeltaManager which allows to filter which session attributes actually get replicated (not yet committed). This is useful, because many applications - use non-serializable session attributes, so it is not possible to simply replicate everything - do not actually nee