Re: DataSourceUserDatabase questions

2022-01-04 Thread Mark Thomas
4 Jan 2022 13:03:57 Rémy Maucherat : Thanks for the sync improvements. As for the problematic scenarios, sequences like create/remove/create seem confusing when reading the code but do work. Agreed. I think I was getting confused by the possible ways to break it with concurrent requests.

Re: DataSourceUserDatabase questions

2022-01-04 Thread Rémy Maucherat
On Sat, Jan 1, 2022 at 10:07 PM Mark Thomas wrote: > > On 01/01/2022 20:05, Rémy Maucherat wrote: > > On Sat, Jan 1, 2022 at 8:20 PM Mark Thomas wrote: > >> > >> Hi all, > >> > >> Probably questions for Rémy but any input welcome. > >> > >> I'm looking at SpotBugs and it has a few warning for thi

Re: DataSourceUserDatabase questions

2022-01-01 Thread Mark Thomas
On 01/01/2022 20:05, Rémy Maucherat wrote: On Sat, Jan 1, 2022 at 8:20 PM Mark Thomas wrote: Hi all, Probably questions for Rémy but any input welcome. I'm looking at SpotBugs and it has a few warning for this class. My questions are: 1. Should the methods the modify the database (createXXX

Re: DataSourceUserDatabase questions

2022-01-01 Thread Rémy Maucherat
On Sat, Jan 1, 2022 at 8:20 PM Mark Thomas wrote: > > Hi all, > > Probably questions for Rémy but any input welcome. > > I'm looking at SpotBugs and it has a few warning for this class. My > questions are: > > 1. Should the methods the modify the database (createXXX, modifiedXXX, > removedXXX) use

DataSourceUserDatabase questions

2022-01-01 Thread Mark Thomas
Hi all, Probably questions for Rémy but any input welcome. I'm looking at SpotBugs and it has a few warning for this class. My questions are: 1. Should the methods the modify the database (createXXX, modifiedXXX, removedXXX) use writeLock rather than readLock? 2. What sequence of actions b