https://issues.apache.org/bugzilla/show_bug.cgi?id=51972
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=51972
--- Comment #6 from Mark Thomas 2011-10-10 12:22:04 UTC ---
The amount of time spend in the sendRedirect code is likely to be only a small
proportion of the overall request time but there are lots of places where URIs
are manipulated in the
https://issues.apache.org/bugzilla/show_bug.cgi?id=51972
--- Comment #5 from Heikki Vesalainen 2011-10-10
12:13:11 UTC ---
100% difference sounds dramatic, but how many percent of the total response
time is spent in this code? How bad would it make things if the slower (but
more reliable) versio
https://issues.apache.org/bugzilla/show_bug.cgi?id=51972
--- Comment #4 from Mark Thomas 2011-10-10 11:56:08 UTC ---
The home-brew code is used for a good reason - performance. It is currently ~2x
faster than the alternative proposed.
--
Configure bugmail: https://issues.apache.org/bugzilla/use
https://issues.apache.org/bugzilla/show_bug.cgi?id=51972
--- Comment #3 from Heikki Vesalainen 2011-10-08
08:57:00 UTC ---
I would also suggest using the java.net.URI to resolve things in place of any
home-brewn code.
private String toAbsolute(String href) {
URI base = URI.create(requestURI);
https://issues.apache.org/bugzilla/show_bug.cgi?id=51972
--- Comment #2 from Mark Thomas 2011-10-07 22:31:07 UTC ---
Discussion on this topic within the Servlet EG can be followed here:
http://java.net/jira/browse/SERVLET_SPEC-27
Given that I am in favour of supporting protocol relative URLs, I
https://issues.apache.org/bugzilla/show_bug.cgi?id=51972
--- Comment #1 from Mark Thomas 2011-10-05 22:12:49 UTC ---
The JavaDoc for sendRedirect requires that anything that starts with '/' is
treated as server relative. I'm not sure if that is what was intended but it is
certainly what the spec