Re: Closing channel sockets

2018-01-12 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/12/18 3:27 AM, Mark Thomas wrote: > On 12/01/18 08:04, Rémy Maucherat wrote: >> On Fri, Jan 12, 2018 at 12:06 AM, Mark Thomas >> wrote: >> >>> Hi, >>> >>> I've been looking at how we close NIO channels and I think >>> there is an oppor

Re: Closing channel sockets

2018-01-12 Thread Rémy Maucherat
On Fri, Jan 12, 2018 at 9:27 AM, Mark Thomas wrote: > On 12/01/18 08:04, Rémy Maucherat wrote: > > On Fri, Jan 12, 2018 at 12:06 AM, Mark Thomas wrote: > > > >> Hi, > >> > >> I've been looking at how we close NIO channels and I think there is an > >> opportunity for a little clean-up that, in tu

Re: Closing channel sockets

2018-01-12 Thread Mark Thomas
On 12/01/18 08:04, Rémy Maucherat wrote: > On Fri, Jan 12, 2018 at 12:06 AM, Mark Thomas wrote: > >> Hi, >> >> I've been looking at how we close NIO channels and I think there is an >> opportunity for a little clean-up that, in turn, may allow a little >> de-duplication between NIO and NIO2. >> >

Re: Closing channel sockets

2018-01-12 Thread Rémy Maucherat
On Fri, Jan 12, 2018 at 12:06 AM, Mark Thomas wrote: > Hi, > > I've been looking at how we close NIO channels and I think there is an > opportunity for a little clean-up that, in turn, may allow a little > de-duplication between NIO and NIO2. > > Currently, in various places in the codebase we cl

Closing channel sockets

2018-01-11 Thread Mark Thomas
Hi, I've been looking at how we close NIO channels and I think there is an opportunity for a little clean-up that, in turn, may allow a little de-duplication between NIO and NIO2. Currently, in various places in the codebase we close an NIO channel using some variation of: channel.socket().close