Re: CDI and injection issues

2022-11-25 Thread Rémy Maucherat
On Tue, Nov 22, 2022 at 4:11 PM Rémy Maucherat wrote: > > Hi, > > Following a post on the user list, I have looked into CDI and > injection processing in Tomcat standalone (or standalone extended by > CDI) and found the following issues: Ok, so the summary: > a) metadata-complete is done wrong.

Re: CDI and injection issues

2022-11-25 Thread Rémy Maucherat
On Thu, Nov 24, 2022 at 6:15 PM Romain Manni-Bucau wrote: > > Le jeu. 24 nov. 2022 à 16:58, Rémy Maucherat a écrit : > > > On Thu, Nov 24, 2022 at 10:19 AM Romain Manni-Bucau > > wrote: > > > > > > Le jeu. 24 nov. 2022 à 10:13, Rémy Maucherat a écrit : > > > > > > > On Wed, Nov 23, 2022 at 11:1

Re: CDI and injection issues

2022-11-24 Thread Romain Manni-Bucau
Le jeu. 24 nov. 2022 à 16:58, Rémy Maucherat a écrit : > On Thu, Nov 24, 2022 at 10:19 AM Romain Manni-Bucau > wrote: > > > > Le jeu. 24 nov. 2022 à 10:13, Rémy Maucherat a écrit : > > > > > On Wed, Nov 23, 2022 at 11:10 AM Romain Manni-Bucau > > > wrote: > > > > > > > > Well, it is not that s

Re: CDI and injection issues

2022-11-24 Thread Rémy Maucherat
On Thu, Nov 24, 2022 at 10:19 AM Romain Manni-Bucau wrote: > > Le jeu. 24 nov. 2022 à 10:13, Rémy Maucherat a écrit : > > > On Wed, Nov 23, 2022 at 11:10 AM Romain Manni-Bucau > > wrote: > > > > > > Well, it is not that simple. > > > > > > Two notes on that: > > > > > > 1. One point is the API,

Re: CDI and injection issues

2022-11-24 Thread Romain Manni-Bucau
Le jeu. 24 nov. 2022 à 10:13, Rémy Maucherat a écrit : > On Wed, Nov 23, 2022 at 11:10 AM Romain Manni-Bucau > wrote: > > > > Well, it is not that simple. > > > > Two notes on that: > > > > 1. One point is the API, injector and instance manager are the exact same > > API if you want a generic AP

Re: CDI and injection issues

2022-11-24 Thread Rémy Maucherat
On Wed, Nov 23, 2022 at 11:10 AM Romain Manni-Bucau wrote: > > Well, it is not that simple. > > Two notes on that: > > 1. One point is the API, injector and instance manager are the exact same > API if you want a generic API so not sure it should be duplicated with > different names (or said other

Re: CDI and injection issues

2022-11-23 Thread Romain Manni-Bucau
Well, it is not that simple. Two notes on that: 1. One point is the API, injector and instance manager are the exact same API if you want a generic API so not sure it should be duplicated with different names (or said otherwise the Injector API is not generic enough to be worth a tomcat "core" ch

Re: CDI and injection issues

2022-11-23 Thread Rémy Maucherat
On Tue, Nov 22, 2022 at 6:08 PM Romain Manni-Bucau wrote: > > Hmm, how is your injector different from an InstanceManager? ( > https://github.com/apache/tomcat/blob/main/java/org/apache/tomcat/InstanceManager.java > ) > Only by not having all `newInstance` flavors? The plan is to keep on using De

Re: CDI and injection issues

2022-11-22 Thread Romain Manni-Bucau
Hmm, how is your injector different from an InstanceManager? ( https://github.com/apache/tomcat/blob/main/java/org/apache/tomcat/InstanceManager.java ) Only by not having all `newInstance` flavors? Will also need the backgroundProcess (cache cleanup, same as instance manager) and similarly the call

Re: CDI and injection issues

2022-11-22 Thread Rémy Maucherat
On Tue, Nov 22, 2022 at 4:30 PM Romain Manni-Bucau wrote: > > Hi Rémy, > > I put a few comments inline hoping it helps > > > Le mar. 22 nov. 2022 à 16:11, Rémy Maucherat a écrit : > > > Hi, > > > > Following a post on the user list, I have looked into CDI and > > injection processing in Tomcat s

Re: CDI and injection issues

2022-11-22 Thread Romain Manni-Bucau
Hi Rémy, I put a few comments inline hoping it helps Le mar. 22 nov. 2022 à 16:11, Rémy Maucherat a écrit : > Hi, > > Following a post on the user list, I have looked into CDI and > injection processing in Tomcat standalone (or standalone extended by > CDI) and found the following issues: > >

CDI and injection issues

2022-11-22 Thread Rémy Maucherat
Hi, Following a post on the user list, I have looked into CDI and injection processing in Tomcat standalone (or standalone extended by CDI) and found the following issues: a) metadata-complete is done wrong. The spec got retconned some time ago and metadata-complete only means Servlet spec defin