Re: 5.5.27 blocker: URIEncoding UTF-8 broken for 5.5.trunk

2008-08-25 Thread Rainer Jung
I need a small correction: when I delete the available method of the IntermediateInputStream, I can neither reproduce the redirect problem, nor bz44494. My test against bz44494 was wrong. Nevertheless I would strongly prefer the removal of conv.recycle in convertURI in the Adapter code, because I

Re: 5.5.27 blocker: URIEncoding UTF-8 broken for 5.5.trunk

2008-08-25 Thread Rainer Jung
Unfortunately removing the available() method agains gives us back 44494. But there is some hope. B2CConverter gets used for two different things: 1) It is associated with a request and used inside the adapter to decode the URI. In this case, it seems that during the lifetime of the ByteChunk u

Re: 5.5.27 blocker: URIEncoding UTF-8 broken for 5.5.trunk

2008-08-25 Thread Rainer Jung
It's the available() methde of the class IntermediateInputStream contained in B2CConverter. It doesn't exist in 6.0. If I comment it out in 5.5 trunk. the problem is gone. The method was first introduced in http://svn.apache.org/viewvc/tomcat/connectors/trunk/util/java/org/apache/tomcat/util/buf/

Re: 5.5.27 blocker: URIEncoding UTF-8 broken for 5.5.trunk

2008-08-25 Thread Rainer Jung
OK, cancelled my appointment. More info: I backported all functional changes in o.a.tomcat.util.buf from tc6.x to tc5.5 and can't reproduce the problem any more. Those are very few changes. I'll narrow it down some more during the next hour. Stay tuned. Rainer Rainer Jung schrieb: > Filip Hanik

Re: 5.5.27 blocker: URIEncoding UTF-8 broken for 5.5.trunk

2008-08-25 Thread Rainer Jung
Filip Hanik - Dev Lists schrieb: > Thanks Rainer, I will take a look at it tonight Thank you! Last info chunk for today: in CoyoteAdapter.convertURI, before the try/catch block that either creates or recycles the B2CConverter, the ByteChunk bc coming from the decodedURI contains the correct URI.

Re: 5.5.27 blocker: URIEncoding UTF-8 broken for 5.5.trunk

2008-08-25 Thread Filip Hanik - Dev Lists
Thanks Rainer, I will take a look at it tonight Filip Rainer Jung wrote: Remy Maucherat schrieb: On Mon, 2008-08-25 at 17:16 +0200, Rainer Jung wrote: If we revert the backport of http://svn.eu.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java?r1=642819

Re: 5.5.27 blocker: URIEncoding UTF-8 broken for 5.5.trunk

2008-08-25 Thread Rainer Jung
Remy Maucherat schrieb: > On Mon, 2008-08-25 at 17:16 +0200, Rainer Jung wrote: >> If we revert the backport of >> >> http://svn.eu.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java?r1=642819&r2=647307&diff_format=h >> >> then the redirect loop is gone, and the usual

Re: 5.5.27 blocker: URIEncoding UTF-8 broken for 5.5.trunk

2008-08-25 Thread Remy Maucherat
On Mon, 2008-08-25 at 17:16 +0200, Rainer Jung wrote: > If we revert the backport of > > http://svn.eu.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java?r1=642819&r2=647307&diff_format=h > > then the redirect loop is gone, and the usual content gets served, but > we

5.5.27 blocker: URIEncoding UTF-8 broken for 5.5.trunk

2008-08-25 Thread Rainer Jung
Hi, URIEncoding="UTF-8" seems to be broken for 5.5.trunk at the moment. The reason is related to one of the fixes for BZ 44494. It doesn't have to do with the fixes for URIEncoding CVE. 6.0.18 works. For 5.5.trunk when URIEncoding="UTF-8" you always get a redirect to the ROOT context start page i