Re: [tomcat] 02/02: LongAdder is a better choice for statistics collection

2023-01-24 Thread Romain Manni-Bucau
Le mar. 24 janv. 2023 à 14:48, Rémy Maucherat a écrit : > On Tue, Jan 24, 2023 at 2:37 PM Romain Manni-Bucau > wrote: > > > > here is the idea https://github.com/apache/tomcat/pull/576 > > People care about stats these days and the performance benefit of > disabling this is simply not going to b

Re: [tomcat] 02/02: LongAdder is a better choice for statistics collection

2023-01-24 Thread Rémy Maucherat
On Tue, Jan 24, 2023 at 2:37 PM Romain Manni-Bucau wrote: > > here is the idea https://github.com/apache/tomcat/pull/576 People care about stats these days and the performance benefit of disabling this is simply not going to be there. Rémy > > Romain Manni-Bucau > @rmannibucau

Re: [tomcat] 02/02: LongAdder is a better choice for statistics collection

2023-01-24 Thread Romain Manni-Bucau
here is the idea https://github.com/apache/tomcat/pull/576 Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

Re: [tomcat] 02/02: LongAdder is a better choice for statistics collection

2023-01-24 Thread Mark Thomas
Patches welcome if that is an itch someone wants to scratch. Mark On 24/01/2023 13:22, Romain Manni-Bucau wrote: If you care about the (perf) diff, shouldnt tomcat have a config to be able to disable stats overhead at all (using a Runnable or Counter {incr(), get()} as abstraction is sufficien

Re: [tomcat] 02/02: LongAdder is a better choice for statistics collection

2023-01-24 Thread Romain Manni-Bucau
If you care about the (perf) diff, shouldnt tomcat have a config to be able to disable stats overhead at all (using a Runnable or Counter {incr(), get()} as abstraction is sufficient) when it is not used (most of the time in dev+prod - ie not sizing/tuning phases)? Romain Manni-Bucau @rmannibucau

Re: [tomcat] 02/02: LongAdder is a better choice for statistics collection

2023-01-24 Thread Rémy Maucherat
On Tue, Jan 24, 2023 at 1:26 PM wrote: > > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch 9.0.x > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > commit a7bf4d84f753d69acb66f5e45f5bc767a1d55e49 > Author: Mark Thomas > Autho

[tomcat] 02/02: LongAdder is a better choice for statistics collection

2023-01-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a7bf4d84f753d69acb66f5e45f5bc767a1d55e49 Author: Mark Thomas AuthorDate: Tue Jan 24 12:22:01 2023 + LongAdder is

[tomcat] 02/02: LongAdder is a better choice for statistics collection

2023-01-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 2df2a763a2ee91c7134d51d8421203dc8e53031f Author: Mark Thomas AuthorDate: Tue Jan 24 12:22:01 2023 + LongAdder is

[tomcat] 02/02: LongAdder is a better choice for statistics collection

2023-01-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 2acb530d27f87ac30acc76f54cfa13fe3f21fa4e Author: Mark Thomas AuthorDate: Tue Jan 24 12:22:01 2023 + LongAdder is a