Re: [VOTE] Release Apache Tomcat 8.5.85 (round 2)

2023-01-18 Thread Christopher Schultz
Konstantin, On 1/18/23 02:03, Konstantin Kolinko wrote: чт, 12 янв. 2023 г. в 23:17, Christopher Schultz : The proposed Apache Tomcat 8.5.85 release is now available for voting. [...] The notable changes compared to 8.5.84 are: - The default value of AccessLogValue's file encoding is no

Re: [VOTE] Release Apache Tomcat 8.5.85 (round 2)

2023-01-17 Thread Konstantin Kolinko
чт, 12 янв. 2023 г. в 23:17, Christopher Schultz : > > The proposed Apache Tomcat 8.5.85 release is now available for voting. > > [...] > > The notable changes compared to 8.5.84 are: > > - The default value of AccessLogValue's file encoding is >now UTF-8. Chris, 1) a typo above, Value -> Valv

Re: [VOTE] Release Apache Tomcat 8.5.85 (round 2)

2023-01-17 Thread Rémy Maucherat
On Thu, Jan 12, 2023 at 9:17 PM Christopher Schultz wrote: > > The proposed Apache Tomcat 8.5.85 release is now available for voting. > > [[[ > Note that the previous tag has been replaced with a new one which > contains the signature files produced during the release-build. The > commit-id of the

Re: [VOTE] Release Apache Tomcat 8.5.85 (round 2)

2023-01-17 Thread Christopher Schultz
All, I could use some more votes for this release. Thanks, -chris On 1/12/23 15:17, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.85 release is now available for voting. [[[ Note that the previous tag has been replaced with a new one which contains the signature files produced du

Re: [VOTE] Release Apache Tomcat 8.5.85 (round 2)

2023-01-13 Thread Christopher Schultz
All, On 1/12/23 15:17, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.85 release is now available for voting. [[[ Note that the previous tag has been replaced with a new one which contains the signature files produced during the release-build. The commit-id of the tag has therefore

Re: [VOTE] Release Apache Tomcat 8.5.85 (round 2)

2023-01-12 Thread Mark Thomas
On 12/01/2023 20:17, Christopher Schultz wrote: The proposed 8.5.85 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.85 (stable) Unit tests pass on Linux. Mark - To unsubscribe, e-mail: dev-uns

Re: [VOTE] Release Apache Tomcat 8.5.85 (round 2)

2023-01-12 Thread Mark Thomas
On 12/01/2023 20:17, Christopher Schultz wrote: The proposed 8.5.85 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.5.85 (stable) Still running the unit tests but I wanted to confirm that I have repeated the build using the new 8.5.85 tag and have confirmed that

[VOTE] Release Apache Tomcat 8.5.85 (round 2)

2023-01-12 Thread Christopher Schultz
The proposed Apache Tomcat 8.5.85 release is now available for voting. [[[ Note that the previous tag has been replaced with a new one which contains the signature files produced during the release-build. The commit-id of the tag has therefore changed as noted later in this message. The files

Re: [VOTE] Release Apache Tomcat 8.5.85

2023-01-12 Thread Mark Thomas
On 12/01/2023 19:01, Christopher Schultz wrote: It looks like the Release Process document should include this: --- Create the tag (Do existing tag stuff, up through but not including the "commit" step) * Run a release build (ant release) * git add res/install-win/tomcat-installer.exe.sig r

Re: [VOTE] Release Apache Tomcat 8.5.85

2023-01-12 Thread Christopher Schultz
Mark, On 1/12/23 13:55, Mark Thomas wrote: Something like: git checkout 8.5.85 git add ... git commit - "Update 8.5.85 tag to include signature files" git tag -d 8.5.85 git push --delete origin 8.5.85 git tag 8.5.85 git push origin 8.5.85 ? I can try that. I wasn't sure if tags were also bra

Re: [VOTE] Release Apache Tomcat 8.5.85

2023-01-12 Thread Christopher Schultz
All, On 1/12/23 13:51, Christopher Schultz wrote: Mark, On 1/11/23 14:45, Mark Thomas wrote: On 11/01/2023 15:49, Christopher Schultz wrote: Mark, On 1/11/23 10:39, Christopher Schultz wrote: Mark, On 1/11/23 04:22, Mark Thomas wrote: On 11/01/2023 01:47, Christopher Schultz wrote: The

Re: [VOTE] Release Apache Tomcat 8.5.85

2023-01-12 Thread Mark Thomas
Something like: git checkout 8.5.85 git add ... git commit - "Update 8.5.85 tag to include signature files" git tag -d 8.5.85 git push --delete origin 8.5.85 git tag 8.5.85 git push origin 8.5.85 ? Mark On 12/01/2023 18:51, Christopher Schultz wrote: Mark, On 1/11/23 14:45, Mark Thomas wrot

Re: [VOTE] Release Apache Tomcat 8.5.85

2023-01-12 Thread Christopher Schultz
Mark, On 1/11/23 14:45, Mark Thomas wrote: On 11/01/2023 15:49, Christopher Schultz wrote: Mark, On 1/11/23 10:39, Christopher Schultz wrote: Mark, On 1/11/23 04:22, Mark Thomas wrote: On 11/01/2023 01:47, Christopher Schultz wrote: The proposed 8.5.85 release is: [X] Broken - do not rele

Re: [VOTE] Release Apache Tomcat 8.5.85

2023-01-11 Thread Mark Thomas
On 11/01/2023 15:49, Christopher Schultz wrote: Mark, On 1/11/23 10:39, Christopher Schultz wrote: Mark, On 1/11/23 04:22, Mark Thomas wrote: On 11/01/2023 01:47, Christopher Schultz wrote: The proposed 8.5.85 release is: [X] Broken - do not release [ ] Stable - go ahead and release as 8.5.

Re: [VOTE] Release Apache Tomcat 8.5.85

2023-01-11 Thread Rémy Maucherat
On Wed, Jan 11, 2023 at 4:49 PM Christopher Schultz wrote: > > Mark, > > On 1/11/23 10:39, Christopher Schultz wrote: > > Mark, > > > > On 1/11/23 04:22, Mark Thomas wrote: > >> On 11/01/2023 01:47, Christopher Schultz wrote: > >> > >>> The proposed 8.5.85 release is: > >>> [X] Broken - do not rel

Re: [VOTE] Release Apache Tomcat 8.5.85

2023-01-11 Thread Christopher Schultz
Mark, On 1/11/23 10:39, Christopher Schultz wrote: Mark, On 1/11/23 04:22, Mark Thomas wrote: On 11/01/2023 01:47, Christopher Schultz wrote: The proposed 8.5.85 release is: [X] Broken - do not release [ ] Stable - go ahead and release as 8.5.85 (stable) The signature files required for a

Re: [VOTE] Release Apache Tomcat 8.5.85

2023-01-11 Thread Christopher Schultz
Mark, On 1/11/23 04:22, Mark Thomas wrote: On 11/01/2023 01:47, Christopher Schultz wrote: The proposed 8.5.85 release is: [X] Broken - do not release [ ] Stable - go ahead and release as 8.5.85 (stable) The signature files required for a reproducible build are missing from the tag. Compa

Re: [VOTE] Release Apache Tomcat 8.5.85

2023-01-11 Thread Mark Thomas
On 11/01/2023 01:47, Christopher Schultz wrote: The proposed 8.5.85 release is: [X] Broken - do not release [ ] Stable - go ahead and release as 8.5.85 (stable) The signature files required for a reproducible build are missing from the tag. Compare https://github.com/apache/tomcat/tree/10.

[VOTE] Release Apache Tomcat 8.5.85

2023-01-10 Thread Christopher Schultz
The proposed Apache Tomcat 8.5.85 release is now available for voting. The notable changes compared to 8.5.84 are: - The default value of AccessLogValue's file encoding is now UTF-8. - Correct a regression in the refactoring that replaced the use of the URL constructors. The regression brok