Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-11 Thread Han Li
> 2022年8月11日 22:56,Christopher Schultz 写道: > > Han, > > On 8/11/22 10:31, Han Li wrote: >>> 2022年8月11日 21:02,Konstantin Kolinko 写道: >>> >>> чт, 11 авг. 2022 г. в 05:21, Han Li : > 2022年8月11日 06:52,Konstantin Kolinko 写道: > > ср, 10 авг. 2022 г. в 13:25, Han Li

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-11 Thread Christopher Schultz
Han, On 8/11/22 10:31, Han Li wrote: 2022年8月11日 21:02,Konstantin Kolinko 写道: чт, 11 авг. 2022 г. в 05:21, Han Li : 2022年8月11日 06:52,Konstantin Kolinko 写道: ср, 10 авг. 2022 г. в 13:25, Han Li mailto:aooo...@gmail.com>>: Mark, Can I make a suggestion related to the ant build script.

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-11 Thread Han Li
> 2022年8月11日 21:02,Konstantin Kolinko 写道: > > чт, 11 авг. 2022 г. в 05:21, Han Li : >> >> >> >>> 2022年8月11日 06:52,Konstantin Kolinko 写道: >>> >>> ср, 10 авг. 2022 г. в 13:25, Han Li >> >: Mark, Can I make a suggestion related to the ant build

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-11 Thread Konstantin Kolinko
чт, 11 авг. 2022 г. в 05:21, Han Li : > > > > > 2022年8月11日 06:52,Konstantin Kolinko 写道: > > > > ср, 10 авг. 2022 г. в 13:25, Han Li > >: > >> > >> Mark, > >> > >> Can I make a suggestion related to the ant build script. Can we add two > >> properties to set the values o

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-11 Thread Mark Thomas
On 10/08/2022 22:16, Christopher Schultz wrote: On 8/10/22 06:02, Mark Thomas wrote: Agreed. I also spotted that adding "do.codesigning=true" would help repeatable builds. I'll get both of those added. I don't think we want that to affect people trying to perform their own builds. It will f

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Han Li
> 2022年8月11日 06:52,Konstantin Kolinko 写道: > > ср, 10 авг. 2022 г. в 13:25, Han Li >: >> >> Mark, >> >> Can I make a suggestion related to the ant build script. Can we add two >> properties to set the values of ` -Duser.language` and `-Duser.country`, >> because in

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Han Li
> 2022年8月11日 05:20,Christopher Schultz 写道: > > Han, > > On 8/10/22 06:25, Han Li wrote: >> Mark, >> Can I make a suggestion related to the ant build script. Can we add two >> properties to set the values of ` -Duser.language` and `-Duser.country`, >> because in the course of my testing I fou

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Konstantin Kolinko
ср, 10 авг. 2022 г. в 13:25, Han Li : > > Mark, > > Can I make a suggestion related to the ant build script. Can we add two > properties to set the values of ` -Duser.language` and `-Duser.country`, > because in the course of my testing I found that some of the unit test > assertions are in Engl

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Christopher Schultz
Han, On 8/10/22 06:25, Han Li wrote: Mark, Can I make a suggestion related to the ant build script. Can we add two properties to set the values of ` -Duser.language` and `-Duser.country`, because in the course of my testing I found that some of the unit test assertions are in English, but th

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Christopher Schultz
Mark, On 8/10/22 06:02, Mark Thomas wrote: On 09/08/2022 20:19, Christopher Schultz wrote: On 8/9/22 14:09, Mark Thomas wrote: This issue is the zip files. Time stamps in zip files use local (yes, local - I didn't mistype that) time. Hence you need to use the same time zone to get a repea

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Han Li
Mark, Can I make a suggestion related to the ant build script. Can we add two properties to set the values of ` -Duser.language` and `-Duser.country`, because in the course of my testing I found that some of the unit test assertions are in English, but there may be cases where the values are c

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-10 Thread Mark Thomas
On 09/08/2022 20:19, Christopher Schultz wrote: On 8/9/22 14:09, Mark Thomas wrote: This issue is the zip files. Time stamps in zip files use local (yes, local - I didn't mistype that) time. Hence you need to use the same time zone to get a repeatable build. We have a few options here: 1

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-09 Thread Han Li
Thanks for your reply. Han > 2022年8月10日 02:36,Christopher Schultz 写道: > > Han, > > On 8/9/22 10:46, Han Li wrote: >>> 2022年8月9日 22:25,Rémy Maucherat 写道: >>> >>> On Tue, Aug 9, 2022 at 12:16 AM Christopher Schultz >>> mailto:ch...@christopherschultz.net>> wrote: The proposed Apache

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-09 Thread Christopher Schultz
Mark, On 8/9/22 14:09, Mark Thomas wrote: On 09/08/2022 16:22, Mark Thomas wrote: On 09/08/2022 15:46, Mark Thomas wrote: On 09/08/2022 15:12, Christopher Schultz wrote: All, I'm curious to find out if anyone is able to build a byte-for-byte identical release given the 8.5.82 tag in GitHub.

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-09 Thread Christopher Schultz
Han, On 8/9/22 10:46, Han Li wrote: 2022年8月9日 22:25,Rémy Maucherat 写道: On Tue, Aug 9, 2022 at 12:16 AM Christopher Schultz mailto:ch...@christopherschultz.net>> wrote: The proposed Apache Tomcat 8.5.82 release is now available for voting. The notable changes compared to 8.5.81 are: - Up

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-09 Thread Christopher Schultz
Mark, On 8/9/22 10:46, Mark Thomas wrote: On 09/08/2022 15:12, Christopher Schultz wrote: All, I'm curious to find out if anyone is able to build a byte-for-byte identical release given the 8.5.82 tag in GitHub. You won't be able to generate the correct signed Windows binaries, of course, bu

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-09 Thread Mark Thomas
On 09/08/2022 16:22, Mark Thomas wrote: On 09/08/2022 15:46, Mark Thomas wrote: On 09/08/2022 15:12, Christopher Schultz wrote: All, I'm curious to find out if anyone is able to build a byte-for-byte identical release given the 8.5.82 tag in GitHub. You won't be able to generate the correct

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-09 Thread Mark Thomas
On 09/08/2022 15:46, Mark Thomas wrote: On 09/08/2022 15:12, Christopher Schultz wrote: All, I'm curious to find out if anyone is able to build a byte-for-byte identical release given the 8.5.82 tag in GitHub. You won't be able to generate the correct signed Windows binaries, of course, but y

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-09 Thread Filip Hanik
On Mon, Aug 8, 2022 at 3:15 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > The proposed Apache Tomcat 8.5.82 release is now available for voting. > > The notable changes compared to 8.5.81 are: > > - Update the packaged version of the Tomcat Native Library to 1.2.35 to > pic

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-09 Thread Han Li
> 2022年8月9日 22:25,Rémy Maucherat 写道: > > On Tue, Aug 9, 2022 at 12:16 AM Christopher Schultz > mailto:ch...@christopherschultz.net>> wrote: >> >> The proposed Apache Tomcat 8.5.82 release is now available for voting. >> >> The notable changes compared to 8.5.81 are: >> >> - Update the packag

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-09 Thread Mark Thomas
On 09/08/2022 15:12, Christopher Schultz wrote: All, I'm curious to find out if anyone is able to build a byte-for-byte identical release given the 8.5.82 tag in GitHub. You won't be able to generate the correct signed Windows binaries, of course, but you should theoretically be able to build

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-09 Thread Rémy Maucherat
On Tue, Aug 9, 2022 at 12:16 AM Christopher Schultz wrote: > > The proposed Apache Tomcat 8.5.82 release is now available for voting. > > The notable changes compared to 8.5.81 are: > > - Update the packaged version of the Tomcat Native Library to 1.2.35 to > pick up Windows binaries built w

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-09 Thread Christopher Schultz
All, I'm curious to find out if anyone is able to build a byte-for-byte identical release given the 8.5.82 tag in GitHub. You won't be able to generate the correct signed Windows binaries, of course, but you should theoretically be able to build everything else. You will need to consult buil

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-09 Thread Christopher Schultz
All, On 8/8/22 18:15, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.82 release is now available for voting. The notable changes compared to 8.5.81 are:  - Update the packaged version of the Tomcat Native Library to 1.2.35 to    pick up Windows binaries built with OpenSSL 1.1.1q.

Re: [VOTE] Release Apache Tomcat 8.5.82

2022-08-08 Thread Han Li
> 2022年8月9日 06:15,Christopher Schultz 写道: > > The proposed Apache Tomcat 8.5.82 release is now available for voting. > > The notable changes compared to 8.5.81 are: > > - Update the packaged version of the Tomcat Native Library to 1.2.35 to > pick up Windows binaries built with OpenSSL 1.1

[VOTE] Release Apache Tomcat 8.5.82

2022-08-08 Thread Christopher Schultz
The proposed Apache Tomcat 8.5.82 release is now available for voting. The notable changes compared to 8.5.81 are: - Update the packaged version of the Tomcat Native Library to 1.2.35 to pick up Windows binaries built with OpenSSL 1.1.1q. - Enable the use of the FIPS provider for TLS enabl