Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-08-19 Thread Mark Thomas
On 17/08/2012 16:50, Konstantin Kolinko wrote: > (regarding DefaultServlet) >>> If it were using the servlet API only, the code were more reusable, >>> both inside and outside of Tomcat. There must be specific issue why >>> Servlet API is not used there. Is the API lacking? >> >> In lot of ways. Fo

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-08-17 Thread Konstantin Kolinko
(regarding DefaultServlet) >> If it were using the servlet API only, the code were more reusable, >> both inside and outside of Tomcat. There must be specific issue why >> Servlet API is not used there. Is the API lacking? > > In lot of ways. For example, where is the API to create or delete > reso

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-07-30 Thread Mark Thomas
On 30/07/2012 15:48, Konstantin Kolinko wrote: > 2012/7/30 Mark Thomas : >> On 30/07/2012 01:16, Konstantin Kolinko wrote: >>> If we remove JNDI stuff from resource handling, one of "challenges" >>> might be to re-implement DefaultServlet using only Servlet API >>> methods. Well, if the former is

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-07-30 Thread Konstantin Kolinko
2012/7/30 Mark Thomas : > On 30/07/2012 01:16, Konstantin Kolinko wrote: >> If we remove JNDI stuff from resource handling, one of "challenges" >> might be to re-implement DefaultServlet using only Servlet API >> methods. Well, if the former is not possible, it might use the new >> resources API (

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-07-30 Thread Mark Thomas
On 30/07/2012 01:16, Konstantin Kolinko wrote: > If we remove JNDI stuff from resource handling, one of "challenges" > might be to re-implement DefaultServlet using only Servlet API > methods. Well, if the former is not possible, it might use the new > resources API (that you are going to implemen

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-07-29 Thread Konstantin Kolinko
2012/6/17 Mark Thomas : > On 16/06/2012 19:18, Mark Thomas wrote: >> >> >> Konstantin Kolinko wrote: >> >>> 2012/6/16 Mark Thomas : > URLs are needed per Servlet API, so they cannot be removed. > Does our "jndi" schema need DirContext as underlying > implementation? Our

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-06-18 Thread Christopher Schultz
Mark, On 6/15/12 1:00 PM, Mark Thomas wrote: > Since this is fairly major work, any objections before I start? I like the unification of all these things. Would this be a good time to consider making Tomcat 7 RTC with such a significant change to the core of the trunk? -chris signature.asc De

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-06-16 Thread Mark Thomas
On 16/06/2012 19:18, Mark Thomas wrote: > > > Konstantin Kolinko wrote: > >> 2012/6/16 Mark Thomas : >>> URLs are needed per Servlet API, so they cannot be removed. Does our "jndi" schema need DirContext as underlying implementation? >>> >>> Our jndi scheme was used to provide

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-06-16 Thread Mark Thomas
Konstantin Kolinko wrote: >2012/6/16 Mark Thomas : >> >>> URLs are needed per Servlet API, so they cannot be removed. Does our >>> "jndi" schema need DirContext as underlying implementation? >> >> Our jndi scheme was used to provide access to resources. I believe >all >> of that will now go. >>

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-06-16 Thread Konstantin Kolinko
2012/6/16 Mark Thomas : > >> URLs are needed per Servlet API, so they cannot be removed. Does our >> "jndi" schema need DirContext as underlying implementation? > > Our jndi scheme was used to provide access to resources. I believe all > of that will now go. > >> I noticed the following commit in a

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-06-16 Thread Mark Thomas
On 16/06/2012 16:28, Konstantin Kolinko wrote: > 2012/6/15 Mark Thomas : >> All, >> >> Servlet 3.1 looks like it is going to introduce 'overlays' or something >> similar along the lines of the enhancement request [1]. >> >> Tomcat already has aliases, VirtualDirContext and resource JAR support - >>

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-06-16 Thread Konstantin Kolinko
2012/6/15 Mark Thomas : > All, > > Servlet 3.1 looks like it is going to introduce 'overlays' or something > similar along the lines of the enhancement request [1]. > > Tomcat already has aliases, VirtualDirContext and resource JAR support - > each implemented slightly differently. Things are alrea

[Proposal] Preparatory refactoring for Resource handling refactoring

2012-06-15 Thread Mark Thomas
All, Servlet 3.1 looks like it is going to introduce 'overlays' or something similar along the lines of the enhancement request [1]. Tomcat already has aliases, VirtualDirContext and resource JAR support - each implemented slightly differently. Things are already rather messy and will get worse i