Re: [PROPOSAL] Explicitly-set the request character encoding when it has been committed

2021-04-06 Thread Mark Thomas
On 05/04/2021 13:19, Christopher Schultz wrote: I'm happy with incremental changes. Making the first change will be an improvement for sure. On the other hand, if code calls request.setCharacterEncoding(non-null) then it will overwrite whatever the request had previously sent (including nu

Re: [PROPOSAL] Explicitly-set the request character encoding when it has been committed

2021-04-05 Thread Christopher Schultz
Mark, On 4/1/21 16:00, Mark Thomas wrote: On 01/04/2021 17:08, Christopher Schultz wrote: The javadoc says that it must be called before reading any request parameters OR calling getReader() but there is only a check for the reader. Maybe we should change the check to: if (using

Re: [PROPOSAL] Explicitly-set the request character encoding when it has been committed

2021-04-01 Thread Mark Thomas
On 01/04/2021 17:08, Christopher Schultz wrote: The javadoc says that it must be called before reading any request parameters OR calling getReader() but there is only a check for the reader. Maybe we should change the check to:     if (usingReader || parametersParsed) {     re

[PROPOSAL] Explicitly-set the request character encoding when it has been committed

2021-04-01 Thread Christopher Schultz
All, Yesterday, I struggled to determine why my application was behaving differently than it had been in the past, and the problem turned out to be that I had inserted a in the filter-chain before my CharacterEncodingFilter. My new was reading a request-parameter. The CharacterEncodingFilte