Re: [PR] tomcat-jdbc check if returned connection is closed [tomcat]

2025-06-06 Thread via GitHub
zyu-godaddy commented on PR #235: URL: https://github.com/apache/tomcat/pull/235#issuecomment-2951104976 While this change makes sense to me, and it should be inexpensive for the jdbc driver I am using (mysql-connector-java), I don't feel comfortable to add this check unconditionally withou

Re: [PR] tomcat-jdbc check if returned connection is closed [tomcat]

2025-06-05 Thread via GitHub
zyu-godaddy commented on PR #235: URL: https://github.com/apache/tomcat/pull/235#issuecomment-2945093472 Cool, I will. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] tomcat-jdbc check if returned connection is closed [tomcat]

2025-06-05 Thread via GitHub
markt-asf commented on PR #235: URL: https://github.com/apache/tomcat/pull/235#issuecomment-2945085547 If you can address Chris's concerns with the test then I don't see why this PR (or one based on it) could not be merged. -- This is an automated message from the Apache Git Service. To r

Re: [PR] tomcat-jdbc check if returned connection is closed [tomcat]

2025-06-05 Thread via GitHub
zyu-godaddy commented on PR #235: URL: https://github.com/apache/tomcat/pull/235#issuecomment-2945031973 Also reported: https://bz.apache.org/bugzilla/show_bug.cgi?id=66502 This bug is the only bug that has been bugging us; otherwise the pool works flawlessly. I wonder if you p