Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-27 Thread via GitHub
markt-asf closed pull request #782: send 416 error to overlapping ranges request URL: https://github.com/apache/tomcat/pull/782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-27 Thread via GitHub
markt-asf commented on PR #782: URL: https://github.com/apache/tomcat/pull/782#issuecomment-2504291618 Tx. Applied a variation manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-25 Thread via GitHub
Chenjp commented on code in PR #782: URL: https://github.com/apache/tomcat/pull/782#discussion_r1857791659 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1231,10 +1231,25 @@ private static boolean validate(ContentRange range) { (range.getEnd()

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-25 Thread via GitHub
Chenjp commented on code in PR #782: URL: https://github.com/apache/tomcat/pull/782#discussion_r1857791659 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1231,10 +1231,25 @@ private static boolean validate(ContentRange range) { (range.getEnd()

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-22 Thread via GitHub
Chenjp commented on PR #782: URL: https://github.com/apache/tomcat/pull/782#issuecomment-2495275038 > I'd like to see similar protection for `Content-Range` when used with partial `PUT`. @markt-asf done with PR #778 -- This is an automated message from the Apache Git Service. To r

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-22 Thread via GitHub
Chenjp commented on PR #782: URL: https://github.com/apache/tomcat/pull/782#issuecomment-2495274861 > I'd like to see similar protection for `Content-Range` when used with partial `PUT`. @markt-asf done with PR #778 -- This is an automated message from the Apache Git Service. To r

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-22 Thread via GitHub
markt-asf commented on code in PR #782: URL: https://github.com/apache/tomcat/pull/782#discussion_r1854564015 ## java/org/apache/catalina/servlets/DefaultServlet.java: ## @@ -1231,10 +1231,25 @@ private static boolean validate(ContentRange range) { (range.getEnd

Re: [PR] send 416 error to overlapping ranges request [tomcat]

2024-11-19 Thread via GitHub
gmshake commented on PR #782: URL: https://github.com/apache/tomcat/pull/782#issuecomment-2485163715 Nice catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[PR] send 416 error to overlapping ranges request [tomcat]

2024-11-18 Thread via GitHub
Chenjp opened a new pull request, #782: URL: https://github.com/apache/tomcat/pull/782 request ranges validation - overlap detection added. * invalid ranges - overlapping: ``` D:\git\github.com>curl http://localhost:55464/index.html -i -H "Range: bytes=10-40,35-50" HTTP/1.1 4