Re: [PR] Merged two loops into one to simplify the logic [tomcat]

markt-asf commented on PR #739: URL: https://github.com/apache/tomcat/pull/739#issuecomment-2211679939 This won't be merged for the reason Chuck explained. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Merged two loops into one to simplify the logic [tomcat]

markt-asf closed pull request #739: Merged two loops into one to simplify the logic URL: https://github.com/apache/tomcat/pull/739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Merged two loops into one to simplify the logic [tomcat]

n828cl commented on PR #739: URL: https://github.com/apache/tomcat/pull/739#issuecomment-2211492415 The proposed change would violate the servlet spec, which requires that filters matching URL patterns must precede those matching servlet names, even when using the same filter for both. See

[PR] Merged two loops into one to simplify the logic [tomcat]

lee-jeong-geun opened a new pull request, #739: URL: https://github.com/apache/tomcat/pull/739 Hello. Reduced the filter addition logic in createFilterChain to a single loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub