markt-asf commented on PR #723:
URL: https://github.com/apache/tomcat/pull/723#issuecomment-2506537080
I'm not seeing a clean way to differentiate between container set 400 status
and application set. Closing this draft PR. I'd be happy to consider a PR if a
clean solution can be found.
-
markt-asf closed pull request #723: Make status code configurable
URL: https://github.com/apache/tomcat/pull/723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
markt-asf commented on PR #723:
URL: https://github.com/apache/tomcat/pull/723#issuecomment-2290947428
Tomcat isn't reserving all 4xx responses. It will close the connection if a
small sub-set of those status codes is used and does so to avoid various
potential security issues. Applications
adwsingh commented on PR #723:
URL: https://github.com/apache/tomcat/pull/723#issuecomment-2289602433
@markt-asf I think Tomcat reserving existing HTTP 4xx responses solely for
its internal use is very restrictive to the application.
What do you feel about, adding a new field in the Coyo
markt-asf commented on PR #723:
URL: https://github.com/apache/tomcat/pull/723#issuecomment-2288295442
Ah, understood. My view is that this is a neat trick but it isn't
sufficient. There are a bunch of places where Tomcat calls
`response.sendError(400,"reason")` where we also want the conne
adwsingh commented on PR #723:
URL: https://github.com/apache/tomcat/pull/723#issuecomment-2286587792
The intention of the PR was to demonstrate if we could safely not close a
connection on a application sent 4xx but always safely close it on HTTP parsing
failures. I wanted to get feedback
markt-asf commented on PR #723:
URL: https://github.com/apache/tomcat/pull/723#issuecomment-2285673300
This PR doesn't appear to change the current behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
adwsingh opened a new pull request, #723:
URL: https://github.com/apache/tomcat/pull/723
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
