Re: [PR] Increase test coverage of WsServerContainer [tomcat]

2024-06-24 Thread via GitHub
JanFojtik21 commented on PR #736: URL: https://github.com/apache/tomcat/pull/736#issuecomment-2186446656 okey, then all good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Increase test coverage of WsServerContainer [tomcat]

2024-06-24 Thread via GitHub
dsoumis commented on PR #736: URL: https://github.com/apache/tomcat/pull/736#issuecomment-2186443680 Thanks for pointing that out. I've applied the fixes required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Increase test coverage of WsServerContainer [tomcat]

2024-06-24 Thread via GitHub
rmaucher commented on PR #736: URL: https://github.com/apache/tomcat/pull/736#issuecomment-2186070382 Did you add "execute.validate=true" to your build.properties file ? Normally we don't use wildcard imports (please avoid that part). Other than that, more test coverage = good. -- This

[PR] Increase test coverage of WsServerContainer [tomcat]

2024-06-23 Thread via GitHub
dsoumis opened a new pull request, #736: URL: https://github.com/apache/tomcat/pull/736 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: