Re: [PR] Forward toString in MessageBytes toStringType [tomcat]

2025-01-29 Thread via GitHub
adwsingh commented on PR #812: URL: https://github.com/apache/tomcat/pull/812#issuecomment-2623032404 @rmaucher in that case is the proposal in my comment acceptable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Forward toString in MessageBytes toStringType [tomcat]

2025-01-29 Thread via GitHub
adwsingh commented on PR #812: URL: https://github.com/apache/tomcat/pull/812#issuecomment-2623032339 @rmaucher in that case is the proposal in my comment acceptable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Forward toString in MessageBytes toStringType [tomcat]

2025-01-29 Thread via GitHub
rmaucher commented on PR #812: URL: https://github.com/apache/tomcat/pull/812#issuecomment-2623028916 toStringType changes the MB type. toString does not. This should indicate that it is wise to not change the MB type in some cases. There's a long history with these changes, you should lo

Re: [PR] Forward toString in MessageBytes toStringType [tomcat]

2025-01-29 Thread via GitHub
rmaucher closed pull request #812: Forward toString in MessageBytes toStringType URL: https://github.com/apache/tomcat/pull/812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Forward toString in MessageBytes toStringType [tomcat]

2025-01-29 Thread via GitHub
adwsingh commented on PR #812: URL: https://github.com/apache/tomcat/pull/812#issuecomment-2623018669 My use case is I want to avoid having to convert byte to String on repeated invocation of [MimeHeaders.getHeader](https://github.com/apache/tomcat/blob/main/java/org/apache/tomcat/util/http

[PR] Forward toString in MessageBytes toStringType [tomcat]

2025-01-29 Thread via GitHub
adwsingh opened a new pull request, #812: URL: https://github.com/apache/tomcat/pull/812 toString doesn't check if the value hasn't been cached and toStringType does it. I couldn't find a reason not to do the same for toString -- This is an automated message from the Apache Git Service. T