Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-17 Thread via GitHub
markt-asf closed pull request #816: Fix null stream issue for resource loading based on relative names URL: https://github.com/apache/tomcat/pull/816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-17 Thread via GitHub
markt-asf commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2663329121 Fixes applied and will be included in the March releases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-06 Thread via GitHub
AmshikaH commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2641001780 > * Tomcat 11 and earlier, skip the `notFoundClassResources` cache if the name starts with '/' I have updated the PR according to this approach. -- This is an automated message fr

Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-06 Thread via GitHub
AmshikaH commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2640799036 > The Java documentation for resource names also states: > > > The methods in ClassLoader use the given String as the name of the resource without applying any absolute/relative trans

Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-06 Thread via GitHub
AmshikaH commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2640684009 > But it does mean it looks like CXF has a bug that should be fixed. Thank you for pointing this out. I will make a report of this via CXF's Jira board. > And given that addURL

Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-06 Thread via GitHub
markt-asf commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2640639410 I think I understand everything that is going on now. The root cause is that Tomcat accepts name for `ClassLoader.getResource(String name)` and friends with a leading '/' whereas th

Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-06 Thread via GitHub
markt-asf commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2640460519 And given that `addURL()` is a protected method, how are you calling it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Fix null stream issue for resource loading based on relative names [tomcat]

2025-02-06 Thread via GitHub
markt-asf commented on PR #816: URL: https://github.com/apache/tomcat/pull/816#issuecomment-2640347996 The Java documentation for resource names also states: > The methods in ClassLoader use the given String as the name of the resource without applying any absolute/relative transforma