robertonr commented on PR #742:
URL: https://github.com/apache/tomcat/pull/742#issuecomment-2505865395
Hello proxies could be implemented dynamically using one of ASM libraries;
Reflection is very expensive and taking into consideration the huge number of
applications using Tomcat this chan
markt-asf commented on PR #742:
URL: https://github.com/apache/tomcat/pull/742#issuecomment-2504405168
You should test the latest version (although I suspect you'll see the same
results).
Use of proxies rather than wrappers was a design decision for jdbc-pool so
it could handle chang
robertonr commented on PR #742:
URL: https://github.com/apache/tomcat/pull/742#issuecomment-2504365369
Hello, I think this change introduced an important performance penalty
comparing my tests using 10.1.26 vs 10.1.27
--
This is an automated message from the Apache Git Service.
To respond
mc1arke commented on PR #742:
URL: https://github.com/apache/tomcat/pull/742#issuecomment-2276512539
Proposed fix in #744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
mc1arke commented on PR #742:
URL: https://github.com/apache/tomcat/pull/742#issuecomment-2275689404
Ah, ok. It's an exception being thrown whilst executing the underlying
statement, which is happening outside the existing try/catch block that unwraps
the exception. I'll raise a Bugzilla re
VRBogdanov commented on PR #742:
URL: https://github.com/apache/tomcat/pull/742#issuecomment-2275626750
Hello,
Same is observed on my side with the following strack trace below. With
latest tomcat 9.091 is ok while after updating to tomcat 9.092/93 it fails. The
problem is that DB in
chrisw-s commented on PR #742:
URL: https://github.com/apache/tomcat/pull/742#issuecomment-2275611258
Just this:
```
try (Statement statement = connection.createStatement();
ResultSet resultSet =
statement.executeQuery("sp_help_fulltext_catalogs")) {
fullTextSearchable
mc1arke commented on PR #742:
URL: https://github.com/apache/tomcat/pull/742#issuecomment-2275124454
@chrisw-s Do you have a stacktrace that shows the exception you're getting
or steps to reproduce the issue?
--
This is an automated message from the Apache Git Service.
To respond to the m
chrisw-s commented on PR #742:
URL: https://github.com/apache/tomcat/pull/742#issuecomment-2274770607
Unfortunately this caused some issues. Where we previously relied on
catching `SQLException` a `java.lang.reflect.UndeclaredThrowableException` is
now being thrown.
--
This is an automat
markt-asf commented on PR #742:
URL: https://github.com/apache/tomcat/pull/742#issuecomment-2244574724
Thanks for the PR. All looks reasonable to me. There are a few bits of
potential clean-up I noticed both in the patch and the surrounding code. I'll
do that after I've merged this PR.
--
markt-asf merged PR #742:
URL: https://github.com/apache/tomcat/pull/742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
11 matches
Mail list logo
