ChristopherSchultz commented on PR #764:
URL: https://github.com/apache/tomcat/pull/764#issuecomment-2491096139
The Servlet 6.2 spec doesn't actually exist yet... at least not in any
published form.
That reference is speculative, assuming that the work being done here will
ultimately
Chenjp commented on PR #764:
URL: https://github.com/apache/tomcat/pull/764#issuecomment-2489895080
@markt-asf @ChristopherSchultz Per HttpServletResponse#sendEarlyHints(),
where can I find "Servlet 6.2" spec?
```java
/**
* Sends a 103 response to the client using the
markt-asf merged PR #764:
URL: https://github.com/apache/tomcat/pull/764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
ChristopherSchultz opened a new pull request, #764:
URL: https://github.com/apache/tomcat/pull/764
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
ChristopherSchultz commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2405802038
I'm not great at github, so I ended up killing this branch and re-creating
it. I will have a follow-up PR soon.
--
This is an automated message from the Apache Git Service.
To r
ChristopherSchultz closed pull request #761: Allow applications to trigger
sending of 103 early hints
URL: https://github.com/apache/tomcat/pull/761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
markt-asf commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2405469155
> I originally wrote this patch just for Tomcat 11 but now that I think
about it, I think I should re-write it for Tomcat 12/main so that the behavior
is consistent regardless of version.
ChristopherSchultz commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2405393185
Tomcat 11 is based on Jakarta EE 11 which does not (yet) have this constant.
I originally wrote this patch just for Tomcat 11 but now that I think about
it, I think I should
ChristopherSchultz commented on code in PR #761:
URL: https://github.com/apache/tomcat/pull/761#discussion_r1795646509
##
java/org/apache/catalina/connector/Response.java:
##
@@ -1069,16 +1069,20 @@ public void sendError(int status, String message)
throws IOException {
ChristopherSchultz commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2405394259
I will also be adding at least one unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
Igal,
On 10/9/24 23:50, isapir (via GitHub) wrote:
isapir commented on code in PR #761:
URL: https://github.com/apache/tomcat/pull/761#discussion_r1794575451
##
java/org/apache/catalina/connector/Response.java:
##
@@ -1069,16 +1069,20 @@ public void sendError(int status, Strin
michael-o commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2404594880
> > Is there now static final for that status code?
>
> Are you talking about
https://github.com/apache/tomcat/blob/main/java/jakarta/servlet/http/HttpServletResponse.java#L406
?
rmaucher commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2404535177
> Is there now static final for that status code?
Are you talking about
https://github.com/apache/tomcat/blob/main/java/jakarta/servlet/http/HttpServletResponse.java#L406
?
--
Thi
michael-o commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2404487095
Is there now static final for that status code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rmaucher commented on code in PR #761:
URL: https://github.com/apache/tomcat/pull/761#discussion_r1794983398
##
java/org/apache/catalina/connector/Response.java:
##
@@ -1209,7 +1213,11 @@ public void setStatus(int status) {
return;
}
-getCoyoteRes
isapir commented on code in PR #761:
URL: https://github.com/apache/tomcat/pull/761#discussion_r1794578764
##
java/org/apache/catalina/connector/Response.java:
##
@@ -1209,7 +1213,11 @@ public void setStatus(int status) {
return;
}
-getCoyoteRespo
isapir commented on code in PR #761:
URL: https://github.com/apache/tomcat/pull/761#discussion_r1794575451
##
java/org/apache/catalina/connector/Response.java:
##
@@ -1069,16 +1069,20 @@ public void sendError(int status, String message)
throws IOException {
return;
ChristopherSchultz commented on PR #761:
URL: https://github.com/apache/tomcat/pull/761#issuecomment-2402893460
I noticed that `Response` does some things that `ResponseFacade` does not.
Specifically, it is sensitive to whether or not there is an *include* in
progress. However, if the `Resp
ChristopherSchultz opened a new pull request, #761:
URL: https://github.com/apache/tomcat/pull/761
Use sendError(103) or setStatus(103).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
19 matches
Mail list logo
