Re: [PATCH] Parallel deployment

2010-11-15 Thread Mark Thomas
On 08/11/2010 18:05, Remy Maucherat wrote: > On Mon, 2010-11-08 at 18:26 +0100, Rainer Jung wrote: >> On 08.11.2010 18:05, Remy Maucherat wrote: >>> I'll up that to -1, with another concern I've just thought about: if >>> using a session id path which includes more than one webapp, the version >>>

Re: [PATCH] Parallel deployment

2010-11-08 Thread Remy Maucherat
On Mon, 2010-11-08 at 18:26 +0100, Rainer Jung wrote: > On 08.11.2010 18:05, Remy Maucherat wrote: > > I'll up that to -1, with another concern I've just thought about: if > > using a session id path which includes more than one webapp, the version > > numbers will have problems matching between th

Re: [PATCH] Parallel deployment

2010-11-08 Thread Mark Thomas
On 08/11/2010 17:26, Rainer Jung wrote: > On 08.11.2010 18:05, Remy Maucherat wrote: >> I'll up that to -1, with another concern I've just thought about: if >> using a session id path which includes more than one webapp, the version >> numbers will have problems matching between the two webapps. >

Re: [PATCH] Parallel deployment

2010-11-08 Thread Rainer Jung
On 08.11.2010 18:05, Remy Maucherat wrote: I'll up that to -1, with another concern I've just thought about: if using a session id path which includes more than one webapp, the version numbers will have problems matching between the two webapps. You mean situations like portals / emptysessionpa

Re: [PATCH] Parallel deployment

2010-11-08 Thread Remy Maucherat
On Mon, 2010-11-08 at 15:46 +, Mark Thomas wrote: > I did consider that approach but rejected it for a couple of reasons: > - Mapper needs to be manager aware - it isn't currently Add a one method interface to be able to perform a session lookup. > - Performance Likely, having to do String m

Re: [PATCH] Parallel deployment

2010-11-08 Thread Mark Thomas
On 08/11/2010 15:40, Remy Maucherat wrote: > On Mon, 2010-11-08 at 14:31 +, Mark Thomas wrote: >> We might be able to avoid that be limiting the version to just integers. >> I think that is reasonable but would like to hear some feedback from others. >> >> That does raise the issue of whether t

Re: [PATCH] Parallel deployment

2010-11-08 Thread Remy Maucherat
On Mon, 2010-11-08 at 14:31 +, Mark Thomas wrote: > We might be able to avoid that be limiting the version to just integers. > I think that is reasonable but would like to hear some feedback from others. > > That does raise the issue of whether to convert the provided version to > a (zero padd

Re: [PATCH] Parallel deployment

2010-11-08 Thread Pid
On 08/11/2010 15:09, Rainer Jung wrote: > Furthermore we could as a convenience convert all dots to underscores and Or s/dots/non-alphanumerics/ p 0x62590808.asc Description: application/pgp-keys signature.asc Description: OpenPGP digital signature

Re: [PATCH] Parallel deployment

2010-11-08 Thread Rainer Jung
On 08.11.2010 15:27, Mark Thomas wrote: Yep - that looks like a left-over from when I was playing with int rather than String for version. I'm still in two minds about that bit. There are places internally where using String makes it easier but limiting it to int would allow us to avoid a bunch o

Re: [PATCH] Parallel deployment

2010-11-08 Thread Mark Thomas
On 06/11/2010 13:00, Rainer Jung wrote: > On 06.11.2010 12:57, Tim Funk wrote: >> When running mod_jk with sticky session, but not using tomcat clustering >> ... Will adding a new version append the version number to the end of >> the session cookie AFTER the engineId (used by mod_jk for determinin

Re: [PATCH] Parallel deployment

2010-11-08 Thread Mark Thomas
On 06/11/2010 11:57, Tim Funk wrote: > This might cause a problem of using == instead of equals() for strcmp > > if (version == (request.getContext().getWebappVersion())) { > mapRequired = false; > } Yep - that looks like a left-over from when I was playing with int rather than String for ver

Re: [PATCH] Parallel deployment

2010-11-06 Thread Rainer Jung
On 06.11.2010 14:00, Rainer Jung wrote: On 06.11.2010 12:57, Tim Funk wrote: When running mod_jk with sticky session, but not using tomcat clustering ... Will adding a new version append the version number to the end of the session cookie AFTER the engineId (used by mod_jk for determining where

Re: [PATCH] Parallel deployment

2010-11-06 Thread Rainer Jung
On 06.11.2010 12:57, Tim Funk wrote: When running mod_jk with sticky session, but not using tomcat clustering ... Will adding a new version append the version number to the end of the session cookie AFTER the engineId (used by mod_jk for determining where to route the request) Tried it and the

Re: [PATCH] Parallel deployment

2010-11-06 Thread Tim Funk
This might cause a problem of using == instead of equals() for strcmp if (version == (request.getContext().getWebappVersion())) { mapRequired = false; } When running mod_jk with sticky session, but not using tomcat clustering ... Will adding a new version append the version number to the e

[PATCH] Parallel deployment

2010-11-05 Thread Mark Thomas
All, The clean-up is in place and I have a patch [1] that adds support for parallel deployment. There is still some work to do before the feature can be used (Manager app needs to be made version aware when listing apps, need to test with clustering, need to write some docs) but I'd like to apply