Github user ukari commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-166806452
Thank both of you very much!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user wenjiezhang2013 commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-166700042
If you read ```The HTTP specification is clear that if no character set is
specified for media sub-types of the "text" media type, the ISO-8859-1
character set mu
Github user ukari commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-166529165
I get it, but it won't work for application/json due to this line
```java
if (ct != null && ct.startsWith("text/")) {
```
---
If your project is set up for i
Github user wenjiezhang2013 commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-166470358
@violetagg is right, it clearly says so from the code
```java
@Override
public void setContentType(String ct) {
if (c
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user violetagg commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-166293296
Ok,
I understand now ...
You misunderstood the usage of that filter ...
It is specified in the documentation [1]:
"encoding - Name of the c
Github user ukari commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165782452
I put that example in email, so you can't see it in github.
https://drive.google.com/file/d/0BxfFe2h4UJX4OEdMZ2dZMTBvYzBvOEl5Ykx4WUxNVWJiRmpj/view?usp=sharing
---
If y
Github user violetagg commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165781265
I meant an example application which we can use to reproduce the issue that
you are describing.
---
If your project is set up for it, you can reply to this email and h
Github user ukari commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165767039
Here is the example
2015-12-18 20:12 GMT+08:00 Wenjie Zhang :
> Here is the document for this filter,
>
http://tomcat.apache.org/tomcat-7.0-doc/config/
Github user wenjiezhang2013 commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165765309
Here is the document for this filter,
http://tomcat.apache.org/tomcat-7.0-doc/config/filter.html#Add_Default_Character_Set_Filter,
base on the code, this shoul
Github user violetagg commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165765057
Can you provide a sample example that demonstrates the issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ukari commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165763957
Oh, you are right, sorry I make the mistake.
But why response's encoding not changed after I set
AddDefaultCharsetFilter?(I mean a HttpServletResponse)
Is the warppe
Github user violetagg commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165754059
Hello,
The encoding specified by the user is provided to the ResponseWrapper.
The ResponseWrapper is provided with the method `doFilter` instead of the
orig
GitHub user ukari opened a pull request:
https://github.com/apache/tomcat/pull/25
Change response character encoding
It seems that encoding was forgotten to be changed in function doFilter().
When I set AddDefaultCharsetFilter in web.xml, like the following:
===
14 matches
Mail list logo
