[GitHub] tomcat pull request: Added support for addWebapp(String, InputStre...

2015-04-16 Thread ThreaT
Github user ThreaT closed the pull request at: https://github.com/apache/tomcat/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] tomcat pull request: Added support for addWebapp(String, InputStre...

2015-03-31 Thread ThreaT
Github user ThreaT commented on the pull request: https://github.com/apache/tomcat/pull/19#issuecomment-87999041 Could you possibly demonstrate how this could be achieved with Tomcat 8? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] tomcat pull request: Added support for addWebapp(String, InputStre...

2015-03-31 Thread markt-asf
Github user markt-asf commented on the pull request: https://github.com/apache/tomcat/pull/19#issuecomment-87983701 No. That is not what I am saying at all. I am saying the functionality you state you want to add (serving JSPs from within a JAR) can already be achieved by exis

[GitHub] tomcat pull request: Added support for addWebapp(String, InputStre...

2015-03-30 Thread ThreaT
Github user ThreaT commented on the pull request: https://github.com/apache/tomcat/pull/19#issuecomment-87801001 Just so we're on the same page, I tried: ``` context = tomcat.addWebapp("/", "jar:file:/home/user/test/MyJar.jar!/com/mvc/view"); ``` Which I found

[GitHub] tomcat pull request: Added support for addWebapp(String, InputStre...

2015-03-30 Thread markt-asf
Github user markt-asf commented on the pull request: https://github.com/apache/tomcat/pull/19#issuecomment-87757450 -1. Servlet 3.0 and later webapps have resource JARs (assuming the JAR is packaged correctly). For single JAR apps, the Tomcat 8 resources implementation can be used

[GitHub] tomcat pull request: Added support for addWebapp(String, InputStre...

2015-03-30 Thread ThreaT
Github user ThreaT commented on the pull request: https://github.com/apache/tomcat/pull/19#issuecomment-87694748 1) I'm not sure 2) Why does it have to? 3) Sorry about formatting. Please see last commit of the three as I removed it. I kept "docBase" in order to accurately overl

[GitHub] tomcat pull request: Added support for addWebapp(String, InputStre...

2015-03-30 Thread kkolinko
Github user kkolinko commented on the pull request: https://github.com/apache/tomcat/pull/19#issuecomment-87686379 1) Bugzilla issue = ? 2) "it is impossible to use the respective jsp files as a webapp" - I do not believe that, with Resources Jars support in Servlet 3.0 spec.

[GitHub] tomcat pull request: Added support for addWebapp(String, InputStre...

2015-03-30 Thread ThreaT
GitHub user ThreaT opened a pull request: https://github.com/apache/tomcat/pull/19 Added support for addWebapp(String, InputStream) When using embedded tomcat, if jsp files are inside the jar file, it is impossible to use the respective jsp files as a webapp unless tomcat accepts