[GitHub] tomcat pull request: [Bug 58242] Scanning jars in classpath to get...

2015-08-16 Thread wangyf2010
Github user wangyf2010 commented on the pull request: https://github.com/apache/tomcat/pull/22#issuecomment-131649270 >My comment regarding separating the refactoring and the functional changes stands. It is not the refactoring I am against, it is the mixing of refactoring and functio

[GitHub] tomcat pull request: [Bug 58242] Scanning jars in classpath to get...

2015-08-16 Thread markt-asf
Github user markt-asf commented on the pull request: https://github.com/apache/tomcat/pull/22#issuecomment-131576391 My comment regarding separating the refactoring and the functional changes stands. It is not the refactoring I am against, it is the mixing of refactoring and functiona

[GitHub] tomcat pull request: [Bug 58242] Scanning jars in classpath to get...

2015-08-15 Thread wangyf2010
Github user wangyf2010 commented on the pull request: https://github.com/apache/tomcat/pull/22#issuecomment-131489980 >it is not thread safe (look at the Java class cache) Please refer AnnotationScanningResult, it will fork a new instance for Java class cache or maps, that mea

[GitHub] tomcat pull request: [Bug 58242] Scanning jars in classpath to get...

2015-08-15 Thread wangyf2010
Github user wangyf2010 commented on the pull request: https://github.com/apache/tomcat/pull/22#issuecomment-131473216 Thanks for your comments, market! Understood your concern, let me explain it one by one: >The patch appears to be quite large for a marginal benfit. Separat

[GitHub] tomcat pull request: [Bug 58242] Scanning jars in classpath to get...

2015-08-13 Thread markt-asf
Github user markt-asf commented on the pull request: https://github.com/apache/tomcat/pull/22#issuecomment-130565904 The patch appears to be quite large for a marginal benfit. Separating the refactoring and the changes into separate commits would enable the true scale of the changes t

[GitHub] tomcat pull request: [Bug 58242] Scanning jars in classpath to get...

2015-08-12 Thread wangyf2010
GitHub user wangyf2010 opened a pull request: https://github.com/apache/tomcat/pull/22 [Bug 58242] Scanning jars in classpath to get annotations in parallel instead of synchronously During tomcat startup, it takes most of time on annotation scanning. For our case, our apps have