Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/76
@kkolinko I will create a ticket.
Unfortunately the issue with WebSocket is due to the JSR-356 specification.
I have spent a lot of time researching this issue and unfortunately that was
the
Github user kkolinko commented on the issue:
https://github.com/apache/tomcat/pull/76
1. Create an entry in Bugzilla and reference this PR, so that this is
correctly mentioned in change log.
http://tomcat.apache.org/bugreport.html
2. I do not mind this utility filter being
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/76
@markt-asf re: `Filter` versus configuration
This could be something that we add now just as a `Filter` but in the
future add a configuration option that just automatically attaches
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/76
Looking at this is on my TODO list to look at before the next release
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/76
@markt-asf Can you please pull this patch in? It'd be great to have it
available in Tomcat 9. Thanks.
---
-
To unsubscribe, e-mai
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/76
@markt-asf I added the documentation that you requested
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For addition
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/76
@markt-asf I added the documentation as per your feedback
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additi
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/76
Sure, I will add the documentation.
Thanks :)
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additiona
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/76
I did wonder if this would be better as configuration on WsFilter but on
reflection a separate Filter looks to be simpler for users to configure.
The patch needs documentation (webapps/docs/
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/76
p.s. I noticed that you sometimes backport code to 8.5 and even further
back. If you accept this patch, and if you want to backport, I can issue a
different patch since this one will not work on 8.x w
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/76
I updated accordingly to save a few CPU cycles and a few bytes of memory
for each Request that hits the Filter.
Cumulative change can be seen at
https://github.com/apache/tomcat/pull/76/file
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/76
Actually, I just noticed that `javax.servlet.Filter` added default no-op
`init()` and `destroy()` (yay!), so this Filter can be modified to implement
`javax.servlet.Filter` instead of extending `javax.
12 matches
Mail list logo
